8350830: Values converted incorrectly when reading TLS session tickets

[nibjen]

Session resumption without server side state was added under JDK-8211018.
While it is TLSv1.2 session resumption, the client hello message is being parsed in SSLSessionImpl for each extensions.

Customer has reported handshake failure and is reproducible locally with exception NegativeArraySizeExceptions when there is ServerNameIndication with size > 127.
According to RFC 3546, the host_name limit allowed is 255.
With a sample testcase when the host_name length is > 127, exception is thrown:
javax.net.ssl|DEBUG|71|Thread-1|2025-04-06 17:13:07.278 UTC|ClientHello.java:825|Negotiated protocol version: TLSv1.2
javax.net.ssl|WARNING|71|Thread-1|2025-04-06 17:13:07.281 UTC|SSLSocketImpl.java:1672|handling exception (
"throwable" : {
java.lang.NegativeArraySizeException: -1
at java.base/sun.security.ssl.SSLSessionImpl.(SSLSessionImpl.java:399)
at java.base/sun.security.ssl.SessionTicketExtension$T12CHSessionTicketConsumer.consume(SessionTicketExtension.java:468)

e.g.
int l = buf.get();
b = new byte[l]; <-------------------- NegativeArraySizeException thrown here when > 127

For TLSv1.3, its not an issue until length > 255.

According to RFC 5077, PSK identity length allowed is <0..2^16-1> and so its value conversion being taken care of under this change.
Master secret is allowed for 48 bytes - master_secret[48], shouldnt be an issue.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed (2 reviews required, with at least 2 Reviewers)

Issue

• JDK-8350830: Values converted incorrectly when reading TLS session tickets (Bug - P3)

Reviewers

• Daniel Jeliński (@djelinski - Reviewer)
• Anthony Scarpino (@ascarpino - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24535/head:pull/24535
$ git checkout pull/24535

Update a local copy of the PR:
$ git checkout pull/24535
$ git pull https://git.openjdk.org/jdk.git pull/24535/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24535

View PR using the GUI difftool:
$ git pr show -t 24535

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24535.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back nibjen! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@nibjen This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8350830: Values converted incorrectly when reading TLS session tickets

Reviewed-by: djelinski, ascarpino

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 608 new commits pushed to the master branch:

• d7e648b: 8355775: Improve symbolic sharing in dynamic constant pool entries
• ca5e0b1: 8282493: Add --with-jcov-modules convenience option
• a72f750: 8356379: Need a proper way to test existence of binary from configure
• ... and 605 more: https://git.openjdk.org/jdk/compare/bd74922157230c866802b4c5269da81e872525aa...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@djelinski, @ascarpino) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

@nibjen The following label will be automatically applied to this pull request:

• security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 02: Full - Incremental (9e0e0bc9)
• 01: Full - Incremental (46d4a6e0)
• 00: Full (81ea059c)

[myankelev]

Nitpick: wildcard import

[djelinski]

Nice. Here's a +1 from me, but please wait for the usual reviewers.

/reviewers 2 reviewer

[openjdk]

⚠️ @nibjen the full name on your profile does not match the author name in this pull requests' HEAD commit. If this pull request gets integrated then the author name from this pull requests' HEAD commit will be used for the resulting commit. If you wish to push a new commit with a different author name, then please run the following commands in a local repository of your personal fork:

$ git checkout JDK-8350830
$ git commit --author='Preferred Full Name <[email protected]>' --allow-empty -m 'Update full name'
$ git push

[openjdk]

@djelinski
The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 2 (with at least 2 Reviewers).

[ascarpino]

I will look at this.. At the time I wrote this I avoided using Record for a reason, but I don't remember why right now.

[nibjen]

@ascarpino @jnimeh since I am waiting for one more review, can you please review it.

[ascarpino]

The changes look good. When stateless was integrated, I remember seeing a problem with Record, but at least from your changes I don't see that problem here. I'm assuming you have tested this change with jdk_security1, 2, 3, and 4?

[nibjen]

Thanks @ascarpino. Yes I have run/verified for all tiers explicitly.

[nibjen]

/integrate

[openjdk]

@nibjen
Your change (at version 9e0e0bc) is now ready to be sponsored by a Committer.

[djelinski]

/sponsor

[openjdk]

Going to push as commit 2c1eb33.
Since your change was applied there have been 622 commits pushed to the master branch:

• daf6fa1: 8356085: AArch64: compiler stub buffer size wrongly depends on ZGC
• 223eec5: 8354219: Automate javax/swing/JComboBox/ComboPopupBug.java
• 52a5583: 8356154: Respecify java.net.Socket constructors that allow creating UDP sockets to throw IllegalArgumentException
• ... and 619 more: https://git.openjdk.org/jdk/compare/bd74922157230c866802b4c5269da81e872525aa...master

Your commit was automatically rebased without conflicts.

[openjdk]

@djelinski @nibjen Pushed as commit 2c1eb33.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.