8352431: java/net/httpclient/EmptyAuthenticate.java uses "localhost"

[vy]

Overhauls EmptyAuthenticate to

• Test all supported HTTP versions (i.e., HTTP/1.1 and HTTP/2)
• Test both clear-text and SSL
• Use HttpServerAdapters.HttpTestServer::create to avoid host-related problems

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8352431: java/net/httpclient/EmptyAuthenticate.java uses "localhost" (Bug - P4)

Reviewers

• Jaikiran Pai (@jaikiran - Reviewer) Review applies to 7b5c8490
• Daniel Fuchs (@dfuch - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24542/head:pull/24542
$ git checkout pull/24542

Update a local copy of the PR:
$ git checkout pull/24542
$ git pull https://git.openjdk.org/jdk.git pull/24542/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24542

View PR using the GUI difftool:
$ git pr show -t 24542

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24542.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back vyazici! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@vy This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8352431: java/net/httpclient/EmptyAuthenticate.java uses "localhost"

Reviewed-by: dfuchs, jpai

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 32 new commits pushed to the master branch:

• 9a3f999: 8346236: Auto vectorization support for various Float16 operations
• 6545e0d: 8353189: [ASAN] memory leak after 8352184
• f94a4f7: 8353847: Remove extra args to System.out.printf in open/test/jdk/java/net/httpclient tests
• ... and 29 more: https://git.openjdk.org/jdk/compare/250eb743c112fbcc45bf2b3ded1c644b19893577...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@jaikiran, @dfuch) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

@vy The following label will be automatically applied to this pull request:

• net

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 03: Full - Incremental (ad9391d5)
• 02: Full - Incremental (f175efe5)
• 01: Full - Incremental (7b5c8490)
• 00: Full (4c6f542e)

[jaikiran]

Thank you for the updates. This looks good to me.

[vy]

/integrate

[openjdk]

@vy
Your change (at version ad9391d) is now ready to be sponsored by a Committer.

[jaikiran]

/sponsor

[openjdk]

Going to push as commit 51b3d6b.
Since your change was applied there have been 32 commits pushed to the master branch:

• 9a3f999: 8346236: Auto vectorization support for various Float16 operations
• 6545e0d: 8353189: [ASAN] memory leak after 8352184
• f94a4f7: 8353847: Remove extra args to System.out.printf in open/test/jdk/java/net/httpclient tests
• ... and 29 more: https://git.openjdk.org/jdk/compare/250eb743c112fbcc45bf2b3ded1c644b19893577...master

Your commit was automatically rebased without conflicts.

[openjdk]

@jaikiran @vy Pushed as commit 51b3d6b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.