8354180: Clean up uses of ObjectMonitor caches

[coleenp]

This is mostly changes from @xmas92 as explained to me plus small cleanup to a read_caches function.
Tested with tier1-4.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8354180: Clean up uses of ObjectMonitor caches (Bug - P4)

Reviewers

• Axel Boldt-Christmas (@xmas92 - Reviewer)
• Fredrik Bredberg (@fbredber - Committer)

Contributors

• Axel Boldt-Christmas <[email protected]>

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24545/head:pull/24545
$ git checkout pull/24545

Update a local copy of the PR:
$ git checkout pull/24545
$ git pull https://git.openjdk.org/jdk.git pull/24545/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24545

View PR using the GUI difftool:
$ git pr show -t 24545

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24545.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back coleenp! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@coleenp This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8354180: Clean  up uses of ObjectMonitor caches

Co-authored-by: Axel Boldt-Christmas <[email protected]>
Reviewed-by: aboldtch, fbredberg

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 163 new commits pushed to the master branch:

• cae7a20: 8353662: Add test for non-local file URL fallback to FTP
• b5d2e25: 8354189: Remove JLI_ReportErrorMessageSys on Windows
• efb5a80: 8353730: TestSubNodeFloatDoubleNegation.java fails with native Float16 support
• ... and 160 more: https://git.openjdk.org/jdk/compare/d894b781b8f245ce8a5d28401c0abb5abb420bc8...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@coleenp The following label will be automatically applied to this pull request:

• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[coleenp]

/contributor add @xmas92

[openjdk]

@coleenp
Contributor Axel Boldt-Christmas <[email protected]> successfully added.

[mlbridge]

Webrevs

• 00: Full (b0d7c484)

[xmas92]

lgtm.

[fbredber]

The code looks good to me. Locking code is rarely self-explanatory, so therefore I really like the added value of the new comments. Thanks!

[coleenp]

Thanks for reviewing Axel and Fredrik.
/integrate

[openjdk]

Going to push as commit 9ead2b7.
Since your change was applied there have been 163 commits pushed to the master branch:

• cae7a20: 8353662: Add test for non-local file URL fallback to FTP
• b5d2e25: 8354189: Remove JLI_ReportErrorMessageSys on Windows
• efb5a80: 8353730: TestSubNodeFloatDoubleNegation.java fails with native Float16 support
• ... and 160 more: https://git.openjdk.org/jdk/compare/d894b781b8f245ce8a5d28401c0abb5abb420bc8...master

Your commit was automatically rebased without conflicts.

[openjdk]

@coleenp Pushed as commit 9ead2b7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.