-
Notifications
You must be signed in to change notification settings - Fork 5.8k
8285888: Clarify that java.net.http.HttpClient do NOT support Digest authentication #24550
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
/csr needed |
👋 Welcome back michaelm! A progress list of the required criteria for merging this PR into |
@Michael-Mc-Mahon This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 42 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
@Michael-Mc-Mahon has indicated that a compatibility and specification (CSR) request is needed for this pull request. @Michael-Mc-Mahon please create a CSR request for issue JDK-8285888 with the correct fix version. This pull request cannot be integrated until the CSR request is approved. |
@Michael-Mc-Mahon The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
Webrevs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change looks good to me.
The copyright year on the file will need an update before integrating.
/integrate |
Going to push as commit e35f67b.
Your commit was automatically rebased without conflicts. |
@Michael-Mc-Mahon Pushed as commit e35f67b. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Hi,
This is a minor doc change to clarify that java.net.http.HttpClient only supports HTTP Basic authentication.
Thanks,
Michael
Progress
Issues
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24550/head:pull/24550
$ git checkout pull/24550
Update a local copy of the PR:
$ git checkout pull/24550
$ git pull https://git.openjdk.org/jdk.git pull/24550/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 24550
View PR using the GUI difftool:
$ git pr show -t 24550
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24550.diff
Using Webrev
Link to Webrev Comment