8354216: Small cleanups relating to Log.DiagnosticHandler

[archiecobbs]

This is split off as a sub-task of JDK-8224228, which seeks to add @SuppressWarnings support for lexical features.

There are a few of small refactoring cleanups possible relating to the nested class Log.DiagnosticHandler.

First, this class is currently declared as a static inner class with an explicit field reference to its outer class (Log) instance. Although protected and non final, this field really should never be changed. Therefore, there is no reason not to just make DiagnosticHandler a non-static inner class. This will slightly simplify the code and eliminate an obscure corner case by which a bug could possibly occur someday.

Secondly, the deferred diagnostics are currently stored in a linked list, and in cases where they must be sorted before being reported, they have to be copied into an array first. A simpler and more space efficient approach would be to just use an ArrayList. Then the sorting variant of the method can just sort the list in place and delegate directly to the non-sorting variant.

Finally, the code can be simplified by replacing a null filter predicate with an always true predicate at construction time instead of at filter time.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8354216: Small cleanups relating to Log.DiagnosticHandler (Sub-task - P4)

Reviewers

• Maurizio Cimadamore (@mcimadamore - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24553/head:pull/24553
$ git checkout pull/24553

Update a local copy of the PR:
$ git checkout pull/24553
$ git pull https://git.openjdk.org/jdk.git pull/24553/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24553

View PR using the GUI difftool:
$ git pr show -t 24553

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24553.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back acobbs! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@archiecobbs This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8354216: Small cleanups relating to Log.DiagnosticHandler

Reviewed-by: mcimadamore

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 786 new commits pushed to the master branch:

• e50af6d: 8354090: Refactor import warning suppression in Check.java
• c4c3edf: 8341402: BigDecimal's square root optimization
• 7e69b98: 8350441: ZGC: Overhaul Page Allocation
• ... and 783 more: https://git.openjdk.org/jdk/compare/ba28119642a7cfa850707a01ce8e589c3a80d416...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@archiecobbs The following labels will be automatically applied to this pull request:

• compiler
• kulla

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (dc3b98c2)
• 00: Full (2e68d7a3)

[mcimadamore]

Looks good

[archiecobbs]

Thanks for the review!

[archiecobbs]

/integrate

[openjdk]

Going to push as commit 4890b74.
Since your change was applied there have been 795 commits pushed to the master branch:

• 7680f70: 8171508: Remove -Dsun.java.launcher.is_altjvm option
• 3131dd1: 8346465: Add a check in setData() to restrict the update of Built-In ICC_Profiles
• af5db51: 8353641: Deprecate core library permission classes for removal
• ... and 792 more: https://git.openjdk.org/jdk/compare/ba28119642a7cfa850707a01ce8e589c3a80d416...master

Your commit was automatically rebased without conflicts.

[openjdk]

@archiecobbs Pushed as commit 4890b74.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.