Skip to content

8354230: Wrong boot jdk for alpine-linux-x64 in GHA #24557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

vidmik
Copy link
Member

@vidmik vidmik commented Apr 9, 2025

JDK-8342984 bumped the minimum boot jdk to JDK 24, and update the boot JDKs used in GHA in the process. Unfortunately the boot jdk for alpine-linux-x64 was incorrectly changed to use the linux-aarch64 version.

Testing: GHA, incl. explicitly triggering/building of alpine-linux-x64


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8354230: Wrong boot jdk for alpine-linux-x64 in GHA (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24557/head:pull/24557
$ git checkout pull/24557

Update a local copy of the PR:
$ git checkout pull/24557
$ git pull https://git.openjdk.org/jdk.git pull/24557/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24557

View PR using the GUI difftool:
$ git pr show -t 24557

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24557.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 9, 2025

👋 Welcome back mikael! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 9, 2025

@vidmik This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8354230: Wrong boot jdk for alpine-linux-x64 in GHA

Reviewed-by: erikj, iris, djelinski, sgehwolf

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 14 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk
Copy link

openjdk bot commented Apr 9, 2025

@vidmik The following label will be automatically applied to this pull request:

  • build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@vidmik vidmik changed the title Draft: 8354230: Wrong boot jdk for alpine-linux-x64 in GHA 8354230: Wrong boot jdk for alpine-linux-x64 in GHA Apr 9, 2025
@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 9, 2025
@mlbridge
Copy link

mlbridge bot commented Apr 9, 2025

Webrevs

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 9, 2025
Copy link
Contributor

@jerboaa jerboaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failure seen in https://github.com/mhaessig/jdk/actions/runs/14376762241/job/40310956644#step:6:478

 configure:85518: Output from java -version was: /__w/jdk/jdk/build/.configure-support/generated-configure.sh: line 85490: /__w/jdk/jdk/bootjdk/jdk/bin/java: cannot execute binary file: Exec format error
configure:85611: error: The path given by --with-boot-jdk does not contain a valid Boot JDK

... is gone in this PR. Looks fine.

@vidmik
Copy link
Member Author

vidmik commented Apr 10, 2025

Thank you for the reviews!

/integrate

@openjdk
Copy link

openjdk bot commented Apr 10, 2025

Going to push as commit 7382ea1.
Since your change was applied there have been 30 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 10, 2025
@openjdk openjdk bot closed this Apr 10, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 10, 2025
@openjdk
Copy link

openjdk bot commented Apr 10, 2025

@vidmik Pushed as commit 7382ea1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build [email protected] integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

5 participants