-
Notifications
You must be signed in to change notification settings - Fork 5.8k
8354230: Wrong boot jdk for alpine-linux-x64 in GHA #24557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back mikael! A progress list of the required criteria for merging this PR into |
@vidmik This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 14 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Failure seen in https://github.com/mhaessig/jdk/actions/runs/14376762241/job/40310956644#step:6:478
configure:85518: Output from java -version was: /__w/jdk/jdk/build/.configure-support/generated-configure.sh: line 85490: /__w/jdk/jdk/bootjdk/jdk/bin/java: cannot execute binary file: Exec format error
configure:85611: error: The path given by --with-boot-jdk does not contain a valid Boot JDK
... is gone in this PR. Looks fine.
Thank you for the reviews! /integrate |
Going to push as commit 7382ea1.
Your commit was automatically rebased without conflicts. |
JDK-8342984 bumped the minimum boot jdk to JDK 24, and update the boot JDKs used in GHA in the process. Unfortunately the boot jdk for alpine-linux-x64 was incorrectly changed to use the linux-aarch64 version.
Testing: GHA, incl. explicitly triggering/building of alpine-linux-x64
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24557/head:pull/24557
$ git checkout pull/24557
Update a local copy of the PR:
$ git checkout pull/24557
$ git pull https://git.openjdk.org/jdk.git pull/24557/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 24557
View PR using the GUI difftool:
$ git pr show -t 24557
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24557.diff
Using Webrev
Link to Webrev Comment