8350029: Illegal invokespecial interface not caught by verification

[dholmes-ora]

As described in the JBS problem statement there was a missing verification check for bad invokespecial call, though it did result in a runtime exception. That gap has now been closed by checking if the target of the invocation is an interface type, which we can check when the type gets loaded as part of the assignability check.

The existing code was very difficult to follow so I have added significant commentary in the verifier. I also improved the naming in the assignability checking code to make it easier to follow. Finally, the existing linkage error was using an incorrect error message to describe the problem it was encountering.

Testing:

• new test case
• tiers 1-3

Thanks

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8350029: Illegal invokespecial interface not caught by verification (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25538/head:pull/25538
$ git checkout pull/25538

Update a local copy of the PR:
$ git checkout pull/25538
$ git pull https://git.openjdk.org/jdk.git pull/25538/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25538

View PR using the GUI difftool:
$ git pr show -t 25538

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25538.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back dholmes! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[openjdk]

@dholmes-ora The following label will be automatically applied to this pull request:

• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (1540b0aa)