Skip to content

8357994: Use "stdin.encoding" for reading System.in with InputStreamReader/Scanner [client] #25543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

vy
Copy link
Contributor

@vy vy commented May 30, 2025

Passes the Charset read from the stdin.encoding system property while creating InputStreamReader or Scanner instances for System.in.

stdin.encoding is a recently added property for Java 25 in JDK-8350703. Employing it throughout the entire code base is addressed by the parent ticket JDK-8356893. JDK-8357994 this PR is addressing is a sub-task of JDK-8356893 and is concerned with only areas related to client libraries.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8357994: Use "stdin.encoding" for reading System.in with InputStreamReader/Scanner [client] (Sub-task - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25543/head:pull/25543
$ git checkout pull/25543

Update a local copy of the PR:
$ git checkout pull/25543
$ git pull https://git.openjdk.org/jdk.git pull/25543/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25543

View PR using the GUI difftool:
$ git pr show -t 25543

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25543.diff

Using Webrev

Link to Webrev Comment

vy added 5 commits May 28, 2025 16:02
`PandocFilter` et al. gets called using the boot JDK,
which doesn't have `stdin.encoding` yet.
Remove assertion in `DOMImplementationRegistry`
@bridgekeeper
Copy link

bridgekeeper bot commented May 30, 2025

👋 Welcome back vyazici! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 30, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot added the rfr Pull request is ready for review label May 30, 2025
@openjdk
Copy link

openjdk bot commented May 30, 2025

@vy The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@mlbridge
Copy link

mlbridge bot commented May 30, 2025

Webrevs

@prrace
Copy link
Contributor

prrace commented May 30, 2025

This is the first I've heard of it but it makes absolutely zero sense here.
The data transfer case is things like "drag and drop" between applications. You'll never see it coming from stdin
And the editor kits will read FILES with some content you want to edit. No one will ever type it in.
So in summary, withdraw this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client [email protected] rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

2 participants