Skip to content

8357821: Revert incorrectly named JavaLangAccess::unchecked* methods #25545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vy
Copy link
Contributor

@vy vy commented May 30, 2025

Reverts certain JDK-8353197 (which implements JavaDoc improvement and precautionary naming for certain unsafe methods in jdk.internal.access.JavaLangAccess) changes that are found to be incorrect. See the JBS issue for details on the followed evaluation process.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8357821: Revert incorrectly named JavaLangAccess::unchecked* methods (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25545/head:pull/25545
$ git checkout pull/25545

Update a local copy of the PR:
$ git checkout pull/25545
$ git pull https://git.openjdk.org/jdk.git pull/25545/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25545

View PR using the GUI difftool:
$ git pr show -t 25545

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25545.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 30, 2025

👋 Welcome back vyazici! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 30, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot added the rfr Pull request is ready for review label May 30, 2025
@openjdk
Copy link

openjdk bot commented May 30, 2025

@vy The following labels will be automatically applied to this pull request:

  • core-libs
  • nio
  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@mlbridge
Copy link

mlbridge bot commented May 30, 2025

Webrevs

@wangweij
Copy link
Contributor

/label remove security

@openjdk
Copy link

openjdk bot commented May 30, 2025

@wangweij
The security label was successfully removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants