8357823: Changes in StringBuilder (JDK-8351443) caused a 1-3% regression in biojava

[RogerRiggs]

Comment out assertions added in JDK-8351443 from AbstractStringBuilder.ensureCapacityNewCoder that increase the codesize, preventing some inlining, and reducing performance

   assert coder == newCoder || newCoder == UTF16 : "bad new coder UTF16 -> LATIN1";
   assert count <= newCapacity : "count exceeds new capacity";

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8357823: Changes in StringBuilder (JDK-8351443) caused a 1-3% regression in biojava (Bug - P3)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25550/head:pull/25550
$ git checkout pull/25550

Update a local copy of the PR:
$ git checkout pull/25550
$ git pull https://git.openjdk.org/jdk.git pull/25550/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25550

View PR using the GUI difftool:
$ git pr show -t 25550

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25550.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back rriggs! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[openjdk]

@RogerRiggs The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (b51f52c9)

[liach]

In javap output, BCI 0-28 and 59-81 are the two assertions. Total code size is 125, and the no-assertion size is 75. Is there any hotspot limit in these two number reached as a result of these two assertions?