Skip to content

8358205: Remove unused JFR array allocation code #25553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

coleenp
Copy link
Contributor

@coleenp coleenp commented May 30, 2025

The JFR code is using ObjArray->allocate() directly rather than going through oopFactory. In Valhalla, the oopFactory code is being changed to account for new array shapes and attributes, so all code should call that instead. Turns out this function is unused, so this change removes it. Tested with tier1-7 with a ShouldNotReachHere(), then jdk/jfr tests with the removal.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8358205: Remove unused JFR array allocation code (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25553/head:pull/25553
$ git checkout pull/25553

Update a local copy of the PR:
$ git checkout pull/25553
$ git pull https://git.openjdk.org/jdk.git pull/25553/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25553

View PR using the GUI difftool:
$ git pr show -t 25553

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25553.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 30, 2025

👋 Welcome back coleenp! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 30, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk
Copy link

openjdk bot commented May 30, 2025

@coleenp The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@coleenp coleenp changed the title Remove unused code that directly allocates an array object without going through OopFactory 8358205: Remove unused JFR array allocation code May 30, 2025
@coleenp coleenp marked this pull request as ready for review May 30, 2025 19:44
@openjdk openjdk bot added the rfr Pull request is ready for review label May 30, 2025
@mlbridge
Copy link

mlbridge bot commented May 30, 2025

Webrevs

@mgronlun
Copy link

/label add hotspot-jfr

@openjdk
Copy link

openjdk bot commented May 31, 2025

@mgronlun
The hotspot-jfr label was successfully added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants