8321713: Harmonize executeTestJvm with create[Limited]TestJavaProcessBuilder

[GoeLin]

I backport this for parity with 17.0.16-oracle based on the push to 21.
I verified that the tests omitted there have not been backported
to 17 in the meantime etc.
Anyways, already the build will detect if a change that needs
to be adapted to this one is backported.

I needed some adaptions on top of the jdk21 change:

Omitted: test/hotspot/jtreg/compiler/arguments/TestCompileThresholdScaling.java
Introduced by "8283807: Handle CompileThreshold the same as other thresholds when scaled with -XX:CompileThresholdScaling".
This eventually is a candidate for backport. Omit for now I think.

Omitted: test/hotspot/jtreg/compiler/c1/TestPrintC1Statistics.java
Introduced by "8296969: C1: PrintC1Statistics is broken after JDK-8292878". JDK-8292878 is
an assembler code cleanup that came in 20.

test/hotspot/jtreg/compiler/loopstripmining/CheckLoopStripMining.java
test/hotspot/jtreg/compiler/vectorapi/TestVectorErgonomics.java
Trivial resolve.

Omitted: test/hotspot/jtreg/gc/x/TestHighUsage.java
Not in 17. Generational ZGC missing.

test/hotspot/jtreg/gc/z/TestHighUsage.java
Trivial resolve. Generational ZGC missing.

Omitted: test/jdk/java/io/File/TempDirDoesNotExist.java
Introduced by "8290313: Produce warning when user specified java.io.tmpdir directory doesn't exist". Not
a candidate for backport, changes behavior.

Omitted: test/jdk/jdk/jfr/jcmd/TestJcmdPreserveRepository.java
Introduced by "8303229: JFR: Preserve disk repository after exit". Would be nice to have
in 17, but larger change with CSR.

The following files need adidtional adaptions, see extra commit:

test/hotspot/jtreg/compiler/c2/Test8062950.java
Was removed with BiasedLocking.

test/hotspot/jtreg/runtime/jni/checked/TestCheckedEnsureLocalCapacity.java
test/jdk/com/sun/management/DiagnosticCommandMBean/DcmdMBeanTestCheckJni.java
Removed by "8297106: Remove the -Xcheck:jni local reference capacity checking" in 20.

test/hotspot/jtreg/vmTestbase/nsk/jvmti/unit/extcallback/Test.java
This test was only added in the backport of "8286490: JvmtiEventControllerPrivate::set_event_callbacks
CLEARING_MASK computation is incorrect" to 17.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• JDK-8321713 needs maintainer approval
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8321713: Harmonize executeTestJvm with create[Limited]TestJavaProcessBuilder (Enhancement - P4 - Requested)

Reviewers

• Ralf Schmelter (@schmelter-sap - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3495/head:pull/3495
$ git checkout pull/3495

Update a local copy of the PR:
$ git checkout pull/3495
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3495/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3495

View PR using the GUI difftool:
$ git pr show -t 3495

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3495.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 01: Full - Incremental (e19ded9b)
• 00: Full (5ce77fa0)

[GoeLin]

GHA failure: build issue: IOException caught during compilation: Connection reset, unrelated.

[GoeLin]

Merged head to restart testing.

[schmelter-sap]

Looks good.

[openjdk]

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[GoeLin]

Thanks for the review!