Skip to content

8320276: Improve class initialization barrier in TemplateTable::_new #3508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MattAlp
Copy link

@MattAlp MattAlp commented Apr 16, 2025

This PR backports 8320276 to support backporting 8338379, see the comment thread linked below. This was a clean backport, though reviewers may want to confirm that the decision to include this function was correct.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8320276 needs maintainer approval

Issue

  • JDK-8320276: Improve class initialization barrier in TemplateTable::_new (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3508/head:pull/3508
$ git checkout pull/3508

Update a local copy of the PR:
$ git checkout pull/3508
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3508/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3508

View PR using the GUI difftool:
$ git pr show -t 3508

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3508.diff


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8320276 needs maintainer approval

Issue

  • JDK-8320276: Improve class initialization barrier in TemplateTable::_new (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3508/head:pull/3508
$ git checkout pull/3508

Update a local copy of the PR:
$ git checkout pull/3508
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3508/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3508

View PR using the GUI difftool:
$ git pr show -t 3508

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3508.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 16, 2025

👋 Welcome back MattAlp! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 16, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 409a39ec8da83d6a0895e7e213604455ebf50485 8320276: Improve class initialization barrier in TemplateTable::_new Apr 16, 2025
@openjdk
Copy link

openjdk bot commented Apr 16, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport label Apr 16, 2025
@MattAlp
Copy link
Author

MattAlp commented Apr 16, 2025

This is in support of #3317, see #3317 (comment)

@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 17, 2025
@mlbridge
Copy link

mlbridge bot commented Apr 17, 2025

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant