8321204: C2: assert(false) failed: node should be in igvn hash table

[satyenme]

Backporting JDK-8321204: C2: assert(false) failed: node should be in igvn hash table. Adjusts assert added by JDK-8024070 and adds additional condition that Node::hash is non zero. Ran GHA Sanity Checks, local Tier 1 and 2 tests. Patch is not clean due to skipping the JDK-8312218 (which is reverted by this commit anyway).

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8321204 needs maintainer approval

Issue

• JDK-8321204: C2: assert(false) failed: node should be in igvn hash table (Bug - P4 - Approved)

Reviewers

• Paul Hohensee (@phohensee - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3520/head:pull/3520
$ git checkout pull/3520

Update a local copy of the PR:
$ git checkout pull/3520
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3520/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3520

View PR using the GUI difftool:
$ git pr show -t 3520

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3520.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back ssubramaniam! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@satyenme This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8321204: C2: assert(false) failed: node should be in igvn hash table

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 117 new commits pushed to the master branch:

• d132468: 8325680: Uninitialised memory in deleteGSSCB of GSSLibStub.c:179
• 18d5503: 8321479: java -D-D crashes
• 6b4fe75: 8314120: Add tests for FileDescriptor.sync
• ... and 114 more: https://git.openjdk.org/jdk17u-dev/compare/96e8c5652053e4ee424d73834dc55d97838c6eea...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 00: Full (ccfe2e36)

[openjdk]

⚠️ @satyenme This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[satyenme]

/approval request for backport. Adjusts assert added by JDK-8024070, and adds additional condition that Node::hash is non zero.

Risk: Low-Medium Tip change was merged in April 2024, is essentially just adding an additional condition to an assert. Touches compilation logic. Only affects debug builds.

Testing:

• GHA Sanity Checks
• Tier 1 and 2 tests locally

[openjdk]

@satyenme
8321204: The approval request has been created successfully.

[satyenme]

/integrate

[openjdk]

@satyenme
Your change (at version ccfe2e3) is now ready to be sponsored by a Committer.

[phohensee]

/sponsor

[openjdk]

Going to push as commit 80cfe11.
Since your change was applied there have been 117 commits pushed to the master branch:

• d132468: 8325680: Uninitialised memory in deleteGSSCB of GSSLibStub.c:179
• 18d5503: 8321479: java -D-D crashes
• 6b4fe75: 8314120: Add tests for FileDescriptor.sync
• ... and 114 more: https://git.openjdk.org/jdk17u-dev/compare/96e8c5652053e4ee424d73834dc55d97838c6eea...master

Your commit was automatically rebased without conflicts.

[openjdk]

@phohensee @satyenme Pushed as commit 80cfe11.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.