-
Notifications
You must be signed in to change notification settings - Fork 3
Feature/unversioned property updates #249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added new integrate permission that is necessary for unversioned integrations. - Unversioned updates only update version if current version < 0
UnsungHero97
requested changes
Sep 17, 2021
Switch to @query Co-authored-by: Hristo Oskov <[email protected]>
anzioka
reviewed
Sep 27, 2021
...tore/src/main/kotlin/com/openlattice/datastore/data/controllers/DataIntegrationController.kt
Show resolved
Hide resolved
* main: Should check if privileges contains all owner-level privileges, not the other way round Revert "Exposing required function from permissioner temporarily for migration" add entityTypeId to DataSet Revert "add entityTypeId to DataSet" add entityTypeId to DataSet Exposing required function from permissioner temporarily for migration Moved over LegacyPermissionMapstore logic to conductor-client Adding hzmap for legacy_permissions Fixed sql typo error replaced thread.sleep temp fix with exponential retry strategy remove most of the @timed I added in EntitySetService a few @timed in Graph remove some more @timed remove most of the @timed I added add @service, @timed to DataDeletionService adding @timed to HazelcastAuthorizationService adding @timed to EntitySetService add api name to logging # Conflicts: # datastore/src/main/java/com/openlattice/datastore/data/controllers/DataController.java
UnsungHero97
approved these changes
Sep 30, 2021
anzioka
approved these changes
Sep 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should significantly reduce the vacuum pressure on our stack from integrations by not overwriting existing properties.