Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new configurable parameters for nuclear data processing #3346

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

janmalec
Copy link
Contributor

@janmalec janmalec commented Mar 12, 2025

Description

I have added an optional parameter to openmc.data.njoy.make_ace to specify the number of equi-probable angles. The default value in OpenMC is low, which helps reduce file size but significantly impacts benchmarking. This change ensures OpenMC is immediately useful for benchmarking new libraries.

Since the parameter is optional and defaults to 12, this modification should not introduce any breaking changes.

Fixes #3347

Checklist

  • I have performed a self-review of my own code
  • I have run clang-format (version 15) on any C++ source files (if applicable)
  • I have followed the style guidelines for Python source files (if applicable)
  • I have made corresponding changes to the documentation (if applicable)
  • I have added tests that prove my fix is effective or that my feature works (if applicable)

@janmalec janmalec requested a review from paulromano as a code owner March 12, 2025 11:45
@janmalec janmalec changed the title Njoy path Add new configurable parameters for nuclear data processing Mar 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add optional parameter to make_ace for equi-probable angles needed
2 participants