Skip to content

Further cucumber-jvm recipes and improvements #264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
5 of 7 tasks
timtebeek opened this issue Oct 3, 2022 · 1 comment
Closed
5 of 7 tasks

Further cucumber-jvm recipes and improvements #264

timtebeek opened this issue Oct 3, 2022 · 1 comment
Labels
recipe Recipe request

Comments

@timtebeek
Copy link
Member

timtebeek commented Oct 3, 2022

A tracking issue for a few more cucumber-jvm recipes, to get these out of my head and into a GitHub Issue.
Each individually should be easy enough to contribute and check off here; whenever I or anyone finds the time.

  • Replace needless-regex cucumber expressions with non-regex cucumber expressions
    • @When("^no need for a regex here$") -> @When("no need for a regex here")
    • possibly even convert regexes with capturing groups to instead use {}
  • Convert once upon a time cucumber.api package to io.cucumber
  • Replace old info.cukes groupIds with io.cucumber
  • Replace @Cucumber with @Suite @SelectClasspathResource("some/path")
  • Drop SummaryPrinter marker interface; replace with Plugin interface if not already present
  • Support method references in the cucumber-java8 to cucumber-java migration recipes
  • Migrate cucumber-java8 datatables to annotation based step definitions

Tagging @mlvandijk & @mpkorstanje for review & further suggestions.

pway99 pushed a commit that referenced this issue Oct 10, 2022
* Drop SummaryPrinter #264

* Stream.ofNullable is only in Java 9+
pway99 pushed a commit that referenced this issue Oct 13, 2022
…r checking annotation packages.

Convert cucumber regexes to cucumber expressions where possible #264
@pway99 pway99 moved this to In Progress in OpenRewrite Oct 14, 2022
@okundzich okundzich moved this from In Progress to Recipes Wanted in OpenRewrite Jan 8, 2023
@timtebeek
Copy link
Member Author

Captured both outstanding items as new feature requests on:
cucumber/cucumber-jvm-migration#2
cucumber/cucumber-jvm-migration#3

@github-project-automation github-project-automation bot moved this from Recipes Wanted to Done in OpenRewrite Mar 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
recipe Recipe request
Projects
Archived in project
Development

No branches or pull requests

1 participant