Skip to content

No-Jira: add Must* helpers for each of the flavors of Select specs functions that error when nothing is found #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 18, 2025
Merged

No-Jira: add Must* helpers for each of the flavors of Select specs functions that error when nothing is found #28

merged 1 commit into from
Mar 18, 2025

Conversation

smg247
Copy link
Contributor

@smg247 smg247 commented Mar 18, 2025

These will be generally useful, but specifically added to alert us when openshift/kubernetes test skips are no longer required.

See openshift/kubernetes#2215 (review)

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 18, 2025
@openshift-ci-robot
Copy link

@smg247: This pull request explicitly references no jira issue.

In response to this:

These will be generally useful, but specifically added to alert us when openshift/kubernetes test skips are no longer required.

See openshift/kubernetes#2215 (review)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from deads2k and stbenjam March 18, 2025 20:55
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Mar 18, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: smg247

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 18, 2025
@stbenjam
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 18, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 86b9979 into openshift-eng:main Mar 18, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deads2k deads2k Awaiting requested review from deads2k

@stbenjam stbenjam Awaiting requested review from stbenjam

Assignees

@stbenjam stbenjam

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@smg247 @openshift-ci-robot @stbenjam