[release-v1.15] Align midstream quarkus deps and apply older fixes #1643
Conversation
Signed-off-by: Matthias Wessendorf <[email protected]>
Signed-off-by: Matthias Wessendorf <[email protected]>
In Vert.x 4.5.1, there was a fix to use the OTel default context storage when the Vert.x context storage provider is not invoked on a Vert.x thread. See eclipse-vertx/vertx-tracing#72 Since LoomKafkaProducer invokes the tracer on a virtual thread (or a worker thread), the sending task must be wrapped with the OTel current context. Otherwise, tracing data will be lost at this point. OTel provides an ExecutorService that does just that, so this commit refactors the producer to use an executor service instead of a queue plus manual polling. Important: note that with this implementation, a virtual thread is created for each record, which is different from sending them one after the other with a single thread.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: matzew The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test kn-ekb-kafka-controller-115-on-pull-request |
|
@maschmid: The specified target(s) for Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/test kn-ekb-test-kafka-consumer-115-on-pull-request |
|
@maschmid: The specified target(s) for Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/test kn-ekb-test-print-115-on-pull-request |
|
@maschmid: The specified target(s) for Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/test kn-ekb-test-watch-cm-115-on-pull-request |
|
@maschmid: The specified target(s) for Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/hold |
|
/retest kn-ekb-test-wathola-fetcher-115-on-pull-request |
|
@matzew: The Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/retest kn-ekb-dispatcher-115-on-pull-request |
|
@matzew: The Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/retest kn-ekb-receiver-115-on-pull-request |
|
@matzew: The Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Aligning deps to what Quarkus 3.8.6-SP3-redhat offers:
bump of Vert.x, micrometer and Opentelemetry
Also backporting fix from Thomas matzew#23
since vert.x 4.5.x changed Otel default context.
This fix was - (back than) based on Marek's fix for consumer/producer background thread finishing
knative-extensions#4013
Therefore backporting that too
However, locally I am getting unit test error: