-
Notifications
You must be signed in to change notification settings - Fork 198
Allow creating VMs with emulated TPM device #1306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow creating VMs with emulated TPM device #1306
Conversation
6063928
to
9b4bd72
Compare
Together with metal3-io/metal3-dev-env#848, I'm getting the following inside a VM
|
/test e2e-metal-ipi-ovn-ipv6 Does not seem like related issue at all
|
lgtm, we'll need to update the metal3-dev-env pin when metal3-io/metal3-dev-env#848 lands |
See comments in metal3-io/metal3-dev-env#848 - if we add support for the environment variable directly in the metal3-dev-env role I don't think we need this PR at all (we'd still need to bump the pin though of course) |
9b4bd72
to
8ca091f
Compare
Right, I'll just keep an example of the config.sh so that the usage is documented |
8ca091f
to
0b9ade9
Compare
/test e2e-metal-ipi-ovn-ipv6 The failure looks unrelated |
/approve |
/test e2e-metal-ipi-ovn-ipv6 |
1 similar comment
/test e2e-metal-ipi-ovn-ipv6 |
/lgtm |
/retest-required |
1 similar comment
/retest-required |
/test e2e-metal-ipi |
@mkowalski apologies but the metal3-dev-env pin got bumped via #1312 so this now conflicts, could you remove the We can then override CI if needed since it'll be a non-functional change to the config example, thanks! |
0b9ade9
to
8fbb8a2
Compare
/approve Thanks! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hardys The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/override ci/prow/e2e-metal-ipi |
@hardys: Overrode contexts on behalf of hardys: ci/prow/e2e-metal-ipi In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/override ci/prow/e2e-metal-ipi-ovn-ipv6 |
@hardys: Overrode contexts on behalf of hardys: ci/prow/e2e-metal-ipi-ovn-ipv6 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
No description provided.