Skip to content

Allow creating VMs with emulated TPM device #1306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

mkowalski
Copy link
Member

No description provided.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 1, 2021
@openshift-ci openshift-ci bot requested review from dtantsur and hardys November 1, 2021 10:25
@mkowalski mkowalski force-pushed the allow-tpm-emulator branch 2 times, most recently from 6063928 to 9b4bd72 Compare November 1, 2021 11:00
@mkowalski mkowalski changed the title [WIP] Allow creating VMs with emulated TPM device Allow creating VMs with emulated TPM device Nov 1, 2021
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 1, 2021
@mkowalski
Copy link
Member Author

Together with metal3-io/metal3-dev-env#848, I'm getting the following inside a VM

[root@master-0 ~]# dmesg | grep -i tpm
[    0.000000] efi:  SMBIOS=0x7e9d2000  TPMFinalLog=0x7ebf6000  ACPI=0x7eb7d000  ACPI 2.0=0x7eb7d014  MEMATTR=0x7d4a8018  MOKvar=0x7e975000  TPMEventLog=0x7d4a5018 
[    0.000000] ACPI: TPM2 0x000000007EB75000 00004C (v04 BOCHS  BXPCTPM2 00000001 BXPC 00000001)
[    2.233085] tpm_tis MSFT0101:00: 2.0 TPM (device-id 0x1, rev-id 1)

@mkowalski
Copy link
Member Author

/cc @dtantsur
/cc @hardys

@mkowalski
Copy link
Member Author

/test e2e-metal-ipi-ovn-ipv6

Does not seem like related issue at all

Message: "secrets is forbidden: User \"e2e-test-templates-2cqw2-edituser\" cannot create resource \"secrets\" in API group \"\" in the namespace \"e2e-test-templates-2cqw2\"",

@hardys
Copy link

hardys commented Nov 1, 2021

lgtm, we'll need to update the metal3-dev-env pin when metal3-io/metal3-dev-env#848 lands

@hardys
Copy link

hardys commented Nov 4, 2021

See comments in metal3-io/metal3-dev-env#848 - if we add support for the environment variable directly in the metal3-dev-env role I don't think we need this PR at all (we'd still need to bump the pin though of course)

@mkowalski
Copy link
Member Author

See comments in metal3-io/metal3-dev-env#848 - if we add support for the environment variable directly in the metal3-dev-env role I don't think we need this PR at all (we'd still need to bump the pin though of course)

Right, I'll just keep an example of the config.sh so that the usage is documented

@mkowalski
Copy link
Member Author

/test e2e-metal-ipi-ovn-ipv6

The failure looks unrelated

@hardys
Copy link

hardys commented Nov 16, 2021

/approve

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 16, 2021
@hardys
Copy link

hardys commented Nov 16, 2021

/test e2e-metal-ipi-ovn-ipv6

1 similar comment
@mkowalski
Copy link
Member Author

/test e2e-metal-ipi-ovn-ipv6

@hardys
Copy link

hardys commented Nov 22, 2021

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 22, 2021
@mkowalski
Copy link
Member Author

/retest-required

1 similar comment
@hardys
Copy link

hardys commented Nov 30, 2021

/retest-required

@hardys
Copy link

hardys commented Nov 30, 2021

/test e2e-metal-ipi

@hardys
Copy link

hardys commented Dec 2, 2021

@mkowalski apologies but the metal3-dev-env pin got bumped via #1312 so this now conflicts, could you remove the 01_install_requirements.sh changes (since the bump from my PR will include your TPM changes)?

We can then override CI if needed since it'll be a non-functional change to the config example, thanks!

@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 3, 2021
@openshift-ci openshift-ci bot removed lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Dec 3, 2021
@hardys
Copy link

hardys commented Dec 3, 2021

/approve
/lgtm

Thanks!

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 3, 2021
@openshift-ci
Copy link

openshift-ci bot commented Dec 3, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hardys

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hardys
Copy link

hardys commented Dec 7, 2021

/override ci/prow/e2e-metal-ipi

@openshift-ci
Copy link

openshift-ci bot commented Dec 7, 2021

@hardys: Overrode contexts on behalf of hardys: ci/prow/e2e-metal-ipi

In response to this:

/override ci/prow/e2e-metal-ipi

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hardys
Copy link

hardys commented Dec 7, 2021

/override ci/prow/e2e-metal-ipi-ovn-ipv6

@openshift-ci
Copy link

openshift-ci bot commented Dec 7, 2021

@hardys: Overrode contexts on behalf of hardys: ci/prow/e2e-metal-ipi-ovn-ipv6

In response to this:

/override ci/prow/e2e-metal-ipi-ovn-ipv6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit a2d59cc into openshift-metal3:master Dec 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants