MetalLB E2E tests: Add logs path #1326
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sabinaaledort
force-pushed
the
metallb_e2e_add_logs_path
branch
from
7031b74 to
446e5a5
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: msherif1234 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
lgtm
sabinaaledort
force-pushed
the
metallb_e2e_add_logs_path
branch
from
446e5a5 to
0ad33f2
Compare
msherif1234
reviewed
Dec 7, 2021
metallb/run_e2e.sh
Outdated
| @@ -42,4 +46,4 @@ export RUN_FRR_CONTAINER_ON_HOST_NETWORK=true | |||
| inv e2etest --kubeconfig=$(readlink -f ../../ocp/ostest/auth/kubeconfig) \ | |||
| --service-pod-port=8080 --system-namespaces="metallb-system" --skip-docker \ | |||
| --ipv4-service-range=192.168.10.0/24 --ipv6-service-range=fc00:f853:0ccd:e799::/124 \ | |||
| --skip="${SKIP}" | |||
| --skip="${SKIP}" -e ${TESTS_REPORTS_PATH} | |||
There was a problem hiding this comment.
do u need "${TESTS_REPORTS_PATH}" ?
Setting the logs path to /logs/artifacts/ as this is the openshift-ci artifacts location so the logs will be stored on every CI run.
sabinaaledort
force-pushed
the
metallb_e2e_add_logs_path
branch
from
0ad33f2 to
efc9f81
Compare
|
/lgtm |
|
/test e2e-metal-ipi-ovn-ipv6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting the logs path to
/logs/artifacts/as this is the openshift-ci artifacts location so the logs will be stored on every CI run.