Skip to content

AGENT-1134: Dev-scripts support to build OVE ISO #1745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

AGENT-1134: Dev-scripts support to build OVE ISO #1745

wants to merge 1 commit into from

Conversation

pawanpinjarkar
Copy link
Contributor

@pawanpinjarkar pawanpinjarkar commented Apr 10, 2025 •
edited
Loading

Dev-scripts support to build OVE ISO

  • Reuse make agent target (instead of introducing a new one)
  • Build agent OVE ISO
  • Boot up the required VMs
  • Set custom rendezvous node (Use AGENT_RENDEZVOUS_NODE_HOSTNAME) and auto-configure rendezvousIP via TUI
  • Take TUI screenshots during install flow
  • Verify that the assisted install web UI is running and accessible
  • Increase VCPU allocation for certain operators requiring more resources
  • Install required dependencies
  • Set isolated network to true for truly disconnected OVE env
  • Temporarily skip common steps not relevant for OVE ISO installs
  • Temporarily skip generating unused manifests and config files
  • Reclaim disk space by cleaning up cache and unnecessary files
    (Use **AGENT_CLEANUP_ISO_BUILDER_CACHE_LOCAL_DEV** for local/dev testing only to save the diskspace) Not recommended for CI

To test, set as below

 export AGENT_E2E_TEST_BOOT_MODE=ISO_NO_REGISTRY
 export AGENT_E2E_TEST_SCENARIO=COMPACT_IPV4
 export AGENT_RENDEZVOUS_NODE_HOSTNAME="${CLUSTER_NAME:-ostest}_master_1"
 export AGENT_CLEANUP_ISO_BUILDER_CACHE_LOCAL_DEV=true

 make agent

ISO will be created at
ocp/ostest/iso_builder/<OCP_VERSION>/ove/output/agent-ove.x86_64.iso

@openshift-ci openshift-ci bot requested review from andfasano and celebdor April 10, 2025 13:05
@pawanpinjarkar
Copy link
Contributor Author

/uncc @celebdor
/cc @bfournie @rwsu

@openshift-ci openshift-ci bot requested review from bfournie and rwsu and removed request for celebdor April 10, 2025 13:05
andfasano
andfasano reviewed Apr 11, 2025
View reviewed changes
rwsu
rwsu suggested changes Apr 14, 2025
View reviewed changes
@andfasano
Copy link
Member

@pawanpinjarkar did you also maybe check the clean target with this new boot mode?

@pawanpinjarkar
Copy link
Contributor Author

@pawanpinjarkar did you also maybe check the clean target with this new boot mode?

@andfasano yes, I am cleaning the directory here https://github.com/openshift-metal3/dev-scripts/pull/1745/files#diff-414fad1e37343146b4f215663b307230240277cd0043033465cd5e3360d1eec7R32-R35

@pawanpinjarkar pawanpinjarkar force-pushed the ove-iso-builder branch 3 times, most recently from 9b2f85d to 76461c0 Compare April 22, 2025 22:59
bfournie
bfournie reviewed Apr 23, 2025
View reviewed changes
@pawanpinjarkar pawanpinjarkar requested a review from bfournie April 23, 2025 17:30
@bfournie
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 24, 2025
rwsu
rwsu reviewed Apr 25, 2025
View reviewed changes
@pawanpinjarkar
AGENT-1134: Dev-scripts support to build OVE ISO
b85fa0d 
- Reuse `make agent` target (instead of introducing a new one)
- Build agent OVE ISO
- Boot up the required VMs
- Set custom rendezvous node (Use AGENT_RENDEZVOUS_NODE_HOSTNAME) and auto-configure rendezvousIP via TUI
- Take TUI screenshots during install flow
- Verify that the assisted install web UI is running and accessible
- Reclaim disk space by cleaning up cache and unnecessary files (Use AGENT_CLEANUP_ISO_BUILDER_CACHE_LOCAL_DEV for local/dev testing)
- Increase VCPU allocation for certain operators requiring more resources
- Install required dependencies
- Temporarily skip common steps not relevant for OVE ISO installs
- Temporarily skip generating unused manifests and config files

To test, set as below

    export AGENT_E2E_TEST_BOOT_MODE=ISO_NO_REGISTRY
    export AGENT_E2E_TEST_SCENARIO=COMPACT_IPV4
    export AGENT_RENDEZVOUS_NODE_HOSTNAME="${CLUSTER_NAME:-ostest}_master_1"
    export AGENT_CLEANUP_ISO_BUILDER_CACHE_LOCAL_DEV=true

    make agent

    ISO will be created at
    ocp/ostest/iso_builder/<OCP_VERSION>/ove/output/agent-ove.x86_64.iso
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 25, 2025
rwsu
rwsu reviewed Apr 25, 2025
View reviewed changes
Copy link
Contributor

@rwsu rwsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 25, 2025
@bfournie
Copy link
Contributor

/approve

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Apr 25, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bfournie

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 25, 2025
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Apr 26, 2025 •
edited
Loading

@pawanpinjarkar: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-metal-ipi-bm b85fa0d link true /test e2e-metal-ipi-bm
ci/prow/e2e-metal-ipi-bm-bond b85fa0d link false /test e2e-metal-ipi-bm-bond

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwsu rwsu rwsu requested changes

@andfasano andfasano Awaiting requested review from andfasano

@bfournie bfournie Awaiting requested review from bfournie

Assignees

@rwsu rwsu

@bfournie bfournie

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pawanpinjarkar @andfasano @bfournie @rwsu