Rename bmo-ironic-configmap to metal3-config. #729
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metal3-config is a better name for the configmap and better matches other configmap names. This also matches the patch that was applied to the MAO.
|
Yes, the name of the configmap matches what was just merged into MAO via openshift/machine-api-operator#302. Thanks for making the corresponding change here. |
|
/lgtm |
|
Waiting for CI http://10.8.144.11:8080/job/dev-tools/1008/ |
|
Build SUCCESS, see build http://10.8.144.11:8080/job/dev-tools/1008/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
metal3-config is a better name for the configmap and better
matches other configmap names.