ODC-7666: Used LogViewer of PF for pipeline logs #153
Conversation
|
@lokanandaprabhu: This pull request references ODC-7666 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lokanandaprabhu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
lokanandaprabhu
force-pushed
the
feature/ODC-7666
branch
4 times, most recently
from
7efbd4f to
1cdf05d
Compare
lokanandaprabhu
changed the title
lokanandaprabhu
force-pushed
the
feature/ODC-7666
branch
from
1cdf05d to
f0ad6b5
Compare
lokanandaprabhu
force-pushed
the
feature/ODC-7666
branch
from
f0ad6b5 to
b0bf7e0
Compare
|
@lokanandaprabhu: This pull request references ODC-7666 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Created issues in https://github.com/patternfly/react-log-viewer/issues patternfly/react-log-viewer#78 - While scrolling in LogViewer, if the log content consists of ANSI color code, then after, on scroll up or scroll down, different colors will show up on the connect patternfly/react-log-viewer#77 - LogViewer is not maintaining indentation/removing spacing which is prefix to the log data |
|
@lokanandaprabhu: This pull request references ODC-7666 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
lokanandaprabhu
force-pushed
the
feature/ODC-7666
branch
from
b0bf7e0 to
82307d0
Compare
There was a problem hiding this comment.
Verified looks fine.
Couple of issues in the LogViewer component that need to be followup and fix. Which has been reported patternfly/react-log-viewer#78 and patternfly/react-log-viewer#77
Merging this PR and will create a followup PR once issues get fixed
/lgtm
openshift-merge-bot
bot
merged commit cb184d7
into
openshift-pipelines:main
Story:
https://issues.redhat.com/browse/ODC-7666
Description:
LogViewer component of PatternFly is used for Pipeline logs
Demo:
https://drive.google.com/file/d/1dPHC8a7gMS7azkB0ExSKtSeh_609nZFZ/view?usp=drive_link
https://drive.google.com/file/d/1Hf6UrFVLqh45ZfqV4hbZ11yOt12NHSGk/view?usp=drive_link