SRVKP-6638: PipelineRuns List page doesn't fetch next page data on scroll #161
Conversation
|
@lokanandaprabhu: This pull request references SRVKP-6638 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.18.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lokanandaprabhu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| const [data, filteredData, onFilterChange] = useListPageFilter( | ||
| pipelineRuns, | ||
| filters, | ||
| ); | ||
|
|
||
| // Once OCPBUGS-43538 ticket is closed, use onRowsRendered prop in VirtualizedTable for load more on scroll | ||
| React.useEffect(() => { |
There was a problem hiding this comment.
Can we create a custom hook for it and use it in both the PLR and TR list pages?
openshift-merge-bot
bot
merged commit 14b0032
into
openshift-pipelines:main
|
/cherry-pick release-v1.16.x |
|
@vikram-raj: new pull request created: #166 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Fixes:
https://issues.redhat.com/browse/SRVKP-6638
Description:
VirtualizedTablewhich is exposed to dynamic plugin is missingonRowsRenderedprop which is available inVirtualTableBodyof PatternFly.Created https://issues.redhat.com/browse/OCPBUGS-43538 ticket for that.
Once this ticket is closed, instead of the solution provided in this PR we have to use
onRowsRenderedprop inVirtualizedTableto callnextPageToken.Demo:
----PipelineRun list page---
https://drive.google.com/file/d/1HO6V5AnMSRqVgTTf1hAIT-COVCH2Q701/view?usp=drive_link
----TaskRun list page---
https://drive.google.com/file/d/1FlOn6Zp3aEKxFlAmivy1IiFRWUUYrPyk/view?usp=drive_link