Skip to content

Warning on watchers finalizer #1763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
chmouel opened this issue Sep 11, 2024 · 1 comment · Fixed by #2099
Closed

Warning on watchers finalizer #1763

chmouel opened this issue Sep 11, 2024 · 1 comment · Fixed by #2099
Assignees
@chmouel
Labels
bug Something isn't working refactoring

Comments

@chmouel
Copy link
Member

chmouel commented Sep 11, 2024

∙ 11:36:57 pac-watcher API Warning: metadata.finalizers: "pipelinesascode.tekton.dev": prefer a domain-qualified finalizer name to avoid accidental conflicts with other finalizer writers
∙ 11:36:57 pac-watcher API Warning: metadata.finalizers: "pipelinesascode.tekton.dev": prefer a domain-qualified finalizer name to avoid accidental conflicts with other finalizer writers
@chmouel
Copy link
Member Author

chmouel commented Sep 11, 2024

related syself/cluster-api-provider-hetzner#1455

@chmouel chmouel added the bug Something isn't working label May 22, 2025
@chmouel chmouel self-assigned this May 22, 2025
chmouel added a commit to chmouel/pipelines-as-code that referenced this issue May 22, 2025
@chmouel
chore: Update controller finalizer name to include explicit part
ad0984a 
*   The finalizer name used by the controller was updated.
*   A new constant `FinalizerName` was introduced for the explicit part of the
name.
*   The finalizer name was updated to combine the group name and the new
constant.
*   This change aligns the finalizer naming with common Kubernetes conventions.

Fixes openshift-pipelines#1763

Signed-off-by: Chmouel Boudjnah <[email protected]>
@chmouel chmouel mentioned this issue May 22, 2025
Merged
13 tasks
chmouel added a commit to chmouel/pipelines-as-code that referenced this issue May 22, 2025
@chmouel
chore: Update controller finalizer name to include explicit part
23944fb 
*   The finalizer name used by the controller was updated.
*   A new constant `FinalizerName` was introduced for the explicit part of the
name.
*   The finalizer name was updated to combine the group name and the new
constant.
*   This change aligns the finalizer naming with common Kubernetes conventions.

Fixes openshift-pipelines#1763

Signed-off-by: Chmouel Boudjnah <[email protected]>
@zakisk zakisk closed this as completed in a0bcb6f May 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chmouel chmouel

Labels
bug Something isn't working refactoring
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: Update controller finalizer name to include explicit part chmouel/pipelines-as-code
1 participant
@chmouel