chore: Update controller finalizer name to include explicit part #2099
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This pull request updates the controller's finalizer naming by introducing a new constant and combining it with the group name, aligning with Kubernetes naming conventions.
- Updated the finalizer name assignment in the controller.
- Adjusted the corresponding test to validate the new finalizer format.
- Introduced a new constant FinalizerName in the register package.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| pkg/reconciler/controller_test.go | Updated test assertion to match the new finalizer name format. |
| pkg/reconciler/controller.go | Modified finalizer name initialization to use filepath.Join. |
| pkg/apis/pipelinesascode/register.go | Added a new constant FinalizerName for the explicit finalizer part. |
* The finalizer name used by the controller was updated. * A new constant `FinalizerName` was introduced for the explicit part of the name. * The finalizer name was updated to combine the group name and the new constant. * This change aligns the finalizer naming with common Kubernetes conventions. Fixes openshift-pipelines#1763 Signed-off-by: Chmouel Boudjnah <[email protected]>
chmouel
force-pushed
the
issue-1763-warning-on-watchers-finalizer
branch
from
ad0984a to
23944fb
Compare
|
/test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FinalizerNamewas introduced for the explicit part of thename.
constant.
∙ 12:08:22 pac-watcher API Warning: metadata.finalizers: "pipelinesascode.tekton.dev": prefer a domain-qualified finalizer name including a path (/) to avoid accidental conflicts with other finalizer writersFixes #1763
Changes
Submitter Checklist
📝 Ensure your commit message is clear and informative. Refer to the How to write a git commit message guide. Include the commit message in the PR body rather than linking to an external site (e.g., Jira ticket).
♽ Run make test lint before submitting a PR to avoid unnecessary CI processing. Consider installing pre-commit and running pre-commit install in the repository root for an efficient workflow.
✨ We use linters to maintain clean and consistent code. Run make lint before submitting a PR. Some linters offer a --fix mode, executable with make fix-linters (ensure markdownlint and golangci-lint are installed).
📖 Document any user-facing features or changes in behavior.
🧪 While 100% coverage isn't required, we encourage unit tests for code changes where possible.
🎁 If feasible, add an end-to-end test. See README for details.
🔎 Address any CI test flakiness before merging, or provide a valid reason to bypass it (e.g., token rate limitations).
If adding a provider feature, fill in the following details:
(update the provider documentation accordingly)