Fix GitLab MR Not Updated Issue on Forked Repository

[zakisk]

In this issue MR status was being created by PAC controller but wasn't updated in reconciler (watcher) and 404 Not Found was noticed in logs:

{"level":"error","ts":"2025-01-22T09:49:03.343Z","logger":"pac-watcher","caller":"events/emit.go:46","msg":"cannot set status with the GitLab token because of: 404 Not Found",...}

this was happening due to wrong Event.SourceProjectID. In implementation of SetClinet func of GitLab provider, if provider.SourceProjectID is empty (0) then it project is fetched from GitLab API (I think this is intended for incoming webhook and workable when sourceProject and targetProject are same raising MR in same repo), but when MR is from a "Forked" respository they are different. and as ParsePayload is only called in controller (really intended for that), when SetClient is called in pac-watcher code provider.SourceProjectID is empty here. But before SetClient is called in reconciler, detectProvider is called there, and detectProvider in its definition calls buildEventFromPipelineRun which sets Event.SourceProjectID and Event.TargetProjectID.

Solution

I am assigning event.SourceProjectID from runevent.TargetProjectID. and it works

Demo

Screencast.from.2025-01-22.18-12-28.mp4

https://issues.redhat.com/browse/SRVKP-6100

Changes

Submitter Checklist

• 📝 Ensure your commit message is clear and informative. Refer to the How to write a git commit message guide. Include the commit message in the PR body rather than linking to an external site (e.g., Jira ticket).

• ♽ Run make test lint before submitting a PR to avoid unnecessary CI processing. Consider installing pre-commit and running pre-commit install in the repository root for an efficient workflow.

• ✨ We use linters to maintain clean and consistent code. Run make lint before submitting a PR. Some linters offer a --fix mode, executable with make fix-linters (ensure markdownlint and golangci-lint are installed).

• 📖 Document any user-facing features or changes in behavior.

• 🧪 While 100% coverage isn't required, we encourage unit tests for code changes where possible.

• 🎁 If feasible, add an end-to-end test. See README for details.

• 🔎 Address any CI test flakiness before merging, or provide a valid reason to bypass it (e.g., token rate limitations).

• If adding a provider feature, fill in the following details:

Git Provider	Supported
GitHub App	❌️
GitHub Webhook	❌️
Gitea	❌️
GitLab	✅️
Bitbucket Cloud	❌️
Bitbucket Server	❌️

(update the documentation accordingly)

[chmouel]

In a scenario where the source repository is forked and a merge request (MR) is created on the upstream repository, runevent.SourceProjectID will not be 0 when SetClient is called from the pac-watcher code. This is because, in the controller, SourceProjectID is set in the annotation of the pull request, and runevent.SourceProjectID is set before SetClient is called. Therefore, we need to take the ID from runevent.SourceProjectID.

[chmouel]

rephrased with proper english ^

[zakisk]

sounds good!