fix: correct the issues with obtaining pr or branch name #1901
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
l-qing
force-pushed
the
fix/get-pr-branch-name
branch
from
c75f739 to
cf613ef
Compare
|
E2e failure is unrelated to code changes, but is related to the environment being unable to pull the image. $ docker pull registry.access.redhat.com/ubi9/ubi-micro
Using default tag: latest
Error response from daemon: failed to resolve reference "registry.access.redhat.com/ubi9/ubi-micro:latest": unexpected status from HEAD request to https://registry.access.redhat.com/v2/ubi9/ubi-micro/manifests/latest: 503 Service Unavailablehttps://bitbucket.org/cboudjna/pac-e2e-tests/pull-requests/2975/overview The pod errored with the message: "Back-off pulling image "registry.access.redhat.com/ubi9/ubi-micro": ErrImagePull: failed to pull and unpack image "registry.access.redhat.com/ubi9/ubi-micro:latest": failed to resolve reference "registry.access.redhat.com/ubi9/ubi-micro:latest": unexpected status from HEAD request to https://registry.access.redhat.com/v2/ubi9/ubi-micro/manifests/latest: 503 Service Unavailable." |
|
@l-qing yes there is something wrong with |
|
/test |
|
/retest |
|
/test go-testing |
|
this LGTM to me but can we have a better commit message ,i had to reread multiple time to understand what it does, ie |
|
/ok-to-test |
|
/assign @savitaashture |
l-qing
force-pushed
the
fix/get-pr-branch-name
branch
4 times, most recently
from
0a0aeee to
6083735
Compare
|
/lgtm we can merge this when e2e ci is green |
|
/retest |
|
/test go-testing |
This commit fixes a bug in parsing pipeline control comments (e.g., /test, /retest, /cancel) when branch names contain command keywords like "/test". Previously, the code would incorrectly split comments with such branch names, causing failures. Key improvements: - Use `strings.SplitN` to split only on the first instance of the command keyword. - Add support for comments with key=value pairs after the pipeline name. - Include test cases for branch names containing "/test" and comments with `key=value` pairs. Example: Before: Branch "feature/test-new" would break parsing due to multiple splits on "/test" keyword. After: The code now correctly processes branch names with command keywords and handles key=value pairs. The parsing is now more robust for real-world scenarios.
l-qing
force-pushed
the
fix/get-pr-branch-name
branch
from
6083735 to
5cd45f2
Compare
|
/retest |
|
@l-qing our cluster is not running during the Europe/Western Asia night 🙇🏻 rerunning it now |
|
/lgtm |
LGTM Vote BreakdownCurrent valid votes: 1/2
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Submitter Checklist
📝 Ensure your commit message is clear and informative. Refer to the How to write a git commit message guide. Include the commit message in the PR body rather than linking to an external site (e.g., Jira ticket).
♽ Run make test lint before submitting a PR to avoid unnecessary CI processing. Consider installing pre-commit and running pre-commit install in the repository root for an efficient workflow.
✨ We use linters to maintain clean and consistent code. Run make lint before submitting a PR. Some linters offer a --fix mode, executable with make fix-linters (ensure markdownlint and golangci-lint are installed).
📖 Document any user-facing features or changes in behavior.
🧪 While 100% coverage isn't required, we encourage unit tests for code changes where possible.
🎁 If feasible, add an end-to-end test. See README for details.
🔎 Address any CI test flakiness before merging, or provide a valid reason to bypass it (e.g., token rate limitations).