-
Notifications
You must be signed in to change notification settings - Fork 103
Use KO for building and pushing images #1913
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Deploying pipelines-as-code with
|
Latest commit: |
ae63c19
|
Status: | ✅ Deploy successful! |
Preview URL: | https://8633f5c0.pipelines-as-code.pages.dev |
Branch Preview URL: | https://use-ko.pipelines-as-code.pages.dev |
03345c8
to
91e38b8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As commented, no need for metric with ko
880ef61
to
26b75f0
Compare
This uses the ko tool to build and push images to ghcr.io. Building with docker was crashing when compiling and is much slower than ko. Signed-off-by: Chmouel Boudjnah <[email protected]>
/help |
🤖 Available Commands
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
there is an error with prow 😮💨 🚨 08:19:06 pac-controller prun: tekton validation error: yaml: line 16: could not find expected ':' will fix it another, merging this now |
This uses the ko tool to build and push images to ghcr.io. Since
building with docker has some issues lately.
Signed-off-by: Chmouel Boudjnah [email protected]
Tested as working here: https://github.com/openshift-pipelines/pipelines-as-code/actions/runs/13174009632?pr=1913