Skip to content

Use KO for building and pushing images #1913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 6, 2025
Merged

Use KO for building and pushing images #1913

merged 1 commit into from
Feb 6, 2025

Conversation

chmouel
Copy link
Member

@chmouel chmouel commented Feb 6, 2025

This uses the ko tool to build and push images to ghcr.io. Since
building with docker has some issues lately.

Signed-off-by: Chmouel Boudjnah [email protected]

Tested as working here: https://github.com/openshift-pipelines/pipelines-as-code/actions/runs/13174009632?pr=1913

Copy link

cloudflare-workers-and-pages bot commented Feb 6, 2025

Deploying pipelines-as-code with  Cloudflare Pages  Cloudflare Pages

Latest commit: ae63c19
Status: ✅  Deploy successful!
Preview URL: https://8633f5c0.pipelines-as-code.pages.dev
Branch Preview URL: https://use-ko.pipelines-as-code.pages.dev

View logs

@chmouel chmouel force-pushed the use-ko branch 12 times, most recently from 03345c8 to 91e38b8 Compare February 6, 2025 07:46
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

@enarha enarha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As commented, no need for metric with ko

@chmouel chmouel force-pushed the use-ko branch 4 times, most recently from 880ef61 to 26b75f0 Compare February 6, 2025 08:04
This uses the ko tool to build and push images to ghcr.io.

Building with docker was crashing when compiling and is much slower than ko.

Signed-off-by: Chmouel Boudjnah <[email protected]>
@chmouel
Copy link
Member Author

chmouel commented Feb 6, 2025

/help

Copy link

🤖 Available Commands

Command Description
/assign user1 user2 Assigns users for review to the PR
/unassign user1 user2 Removes assigned users
/label bug feature Adds labels to the PR
/unlabel bug feature Removes labels from the PR
/lgtm Approves the PR if at least 1 org members have commented /lgtm
/merge Merges the PR if it has enough /lgtm approvals
/help Shows this help message

@chmouel
Copy link
Member Author

chmouel commented Feb 6, 2025

job goes down by one hour

from 1h15
image

to ~5mn

image

Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@chmouel
Copy link
Member Author

chmouel commented Feb 6, 2025

there is an error with prow 😮‍💨

🚨 08:19:06 pac-controller prun: tekton validation error: yaml: line 16: could not find expected ':'

will fix it another, merging this now

@chmouel chmouel merged commit 2004afd into main Feb 6, 2025
8 checks passed
@chmouel chmouel deleted the use-ko branch February 6, 2025 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants