fix(golangci-lint): fix forcetypeassert errors #1933
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Go 1.22 introduced a restriction where type assertions in multiple assignments must be standalone. This fix ensures compliance by: - Separating type assertions before passing values to functions. - Adding error handling for failed assertions to prevent runtime panics. - Consolidating duplicate cases for cleaner logic. This resolves golangci-lint 'forcetypeassert' errors. Fixes openshift-pipelines#1932 Signed-off-by: Chmouel Boudjnah <[email protected]>
7 tasks
|
/label fix |
|
✅ Added labels: fix. |
savitaashture
approved these changes
Feb 14, 2025
|
/lgtm |
![pipelines-as-code[bot]](https://avatars.githubusercontent.com/in/112592?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ Pull Request Approved
Approval Status:
- Required Approvals: 1
- Current Approvals: 1
👥 Approved By:
| Reviewer | Permission | Status |
|---|---|---|
| @zakisk | admin |
✅ |
📝 Next Steps
- All required checks must pass
- Branch protection rules apply
- Get a maintainer to use the
/mergecommand to merge the PR
Thank you for your contributions! 🎉
|
/merge |
pipelines-as-code
bot
merged commit 5b6a223
into
openshift-pipelines:main
5 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Go 1.22 introduced a restriction where type assertions in multiple assignments must be standalone.
This fix ensures compliance by:
This resolves golangci-lint 'forcetypeassert' errors.
Fixes #1932