-
Notifications
You must be signed in to change notification settings - Fork 102
fix handle multiline trigger comment var properly #1934
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
pipelines-as-code
merged 2 commits into
openshift-pipelines:main
from
chmouel:fix-handle-multiline-trigger-comment-var-properly
Feb 14, 2025
Merged
fix handle multiline trigger comment var properly #1934
pipelines-as-code
merged 2 commits into
openshift-pipelines:main
from
chmouel:fix-handle-multiline-trigger-comment-var-properly
Feb 14, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Go 1.22 introduced a restriction where type assertions in multiple assignments must be standalone. This fix ensures compliance by: - Separating type assertions before passing values to functions. - Adding error handling for failed assertions to prevent runtime panics. - Consolidating duplicate cases for cleaner logic. This resolves golangci-lint 'forcetypeassert' errors. Fixes openshift-pipelines#1932 Signed-off-by: Chmouel Boudjnah <[email protected]>
I guess its because of PR changes?
|
When using `{{ trigger_comment }}` in a PipelineRun YAML, GitHub comments containing newlines (e.g., `/help`) can break YAML parsing due to improper expansion. This change replaces `\r\n` with `\n` in `trigger_comment`, similar to how `pull_requests_labels` are handled. This ensures valid YAML formatting and avoids parser errors. Fixes openshift-pipelines#1929 Signed-off-by: Chmouel Boudjnah <[email protected]>
90d5cdb
to
66e5059
Compare
@zakisk fixed and green, PTAL 🙏🏻 |
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ Pull Request Approved
Approval Status:
- Required Approvals: 1
- Current Approvals: 1
👥 Approved By:
Reviewer | Permission | Status |
---|---|---|
@zakisk | admin |
✅ |
📝 Next Steps
- All required checks must pass
- Branch protection rules apply
- Get a maintainer to use the
/merge
command to merge the PR
Thank you for your contributions! 🎉
/merge |
0390c98
into
openshift-pipelines:main
7 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submitter Checklist
fix handle multiline trigger_comment var properly
When using
{{ trigger_comment }}
in a PipelineRun YAML, GitHubcomments containing newlines (e.g.,
/help
) can break YAML parsing dueto improper expansion.
This change replaces
\r\n
with\n
intrigger_comment
, similar tohow we did for only \n previously are handled. This ensures valid YAML
formatting and avoids parser errors.
Fixes trigger_comment may screw pipelinerun yaml with the the newline #1929
📝 Ensure your commit message is clear and informative. Refer to the How to write a git commit message guide. Include the commit message in the PR body rather than linking to an external site (e.g., Jira ticket).
♽ Run make test lint before submitting a PR to avoid unnecessary CI processing. Consider installing pre-commit and running pre-commit install in the repository root for an efficient workflow.
✨ We use linters to maintain clean and consistent code. Run make lint before submitting a PR. Some linters offer a --fix mode, executable with make fix-linters (ensure markdownlint and golangci-lint are installed).
📖 Document any user-facing features or changes in behavior.
🧪 While 100% coverage isn't required, we encourage unit tests for code changes where possible.
🎁 If feasible, add an end-to-end test. See README for details.
🔎 Address any CI test flakiness before merging, or provide a valid reason to bypass it (e.g., token rate limitations).
If adding a provider feature, fill in the following details: