Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPLAT-2072: Removed VSphereMultiVCenters feature gate #2231

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vr4manta
Copy link
Contributor

@vr4manta vr4manta commented Mar 13, 2025

SPLAT-2072

Changes

  • Removed the VSphereMultiVCenter feature gate
  • Updated CRD to allow multiple vCenters always

Dependencies

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 13, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 13, 2025

@vr4manta: This pull request references SPLAT-2072 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

SPLAT-2072

Changes

  • Removed the VSphereMultiVCenter feature gate
  • Updated CRD to allow multiple vCenters always

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

openshift-ci bot commented Mar 13, 2025

Hello @vr4manta! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci openshift-ci bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Mar 13, 2025
@vr4manta
Copy link
Contributor Author

/hold
Waiting for other PRs to finish merging

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 13, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 2, 2025

@vr4manta: This pull request references SPLAT-2072 which is a valid jira issue.

In response to this:

SPLAT-2072

Changes

  • Removed the VSphereMultiVCenter feature gate
  • Updated CRD to allow multiple vCenters always

Dependencies

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

openshift-ci bot commented Apr 10, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: vr4manta
Once this PR has been reviewed and has the lgtm label, please assign deads2k for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

openshift-ci bot commented Apr 10, 2025

@vr4manta: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-techpreview ad9f718 link true /test e2e-aws-ovn-techpreview
ci/prow/okd-scos-e2e-aws-ovn ad9f718 link false /test okd-scos-e2e-aws-ovn
ci/prow/minor-e2e-upgrade-minor ad9f718 link true /test minor-e2e-upgrade-minor
ci/prow/e2e-upgrade-out-of-change ad9f718 link true /test e2e-upgrade-out-of-change
ci/prow/e2e-gcp ad9f718 link false /test e2e-gcp
ci/prow/e2e-aws-serial-techpreview ad9f718 link true /test e2e-aws-serial-techpreview
ci/prow/e2e-aws-serial ad9f718 link true /test e2e-aws-serial
ci/prow/e2e-azure ad9f718 link false /test e2e-azure

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants