SPLAT-2078: Removed VSphereStaticIPs feature gate #2232
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@vr4manta: This pull request references SPLAT-2078 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
|
Hello @vr4manta! Some important instructions when contributing to openshift/api: |
openshift-ci
bot
added
the
size/S
|
/test all |
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
/lgtm |
|
@vr4manta: This pull request references SPLAT-2078 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/assign @JoelSpeed |
|
/retest |
|
/retest-required |
|
This feature has been enabled for over a year, so is safe to remove /lgtm /hold but we do need to check that vSphere payload jobs are still passing with this removed /payload-job periodic-ci-openshift-release-master-nightly-4.19-e2e-vsphere-ovn |
openshift-ci
bot
added
the
do-not-merge/hold
|
@JoelSpeed: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/554e2420-1147-11f0-8fae-50b1e402517f-0 |
openshift-ci
bot
added
the
approved
|
@JoelSpeed , the payload-test finish, but failed. It looks to have failed during e2e tests that don't seem related. If it looks ok to you, are you good with removing the hold? |
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
openshift-merge-robot
added
the
needs-rebase
# Conflicts: # payload-command/render/renderassets/rendered_manifests_test.go
openshift-merge-robot
removed
the
needs-rebase
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jcpowermac, JoelSpeed, vr4manta The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
2 similar comments
|
/retest-required |
1 similar comment
|
/retest-required |
|
@JoelSpeed it seems the two aws jobs keep failing for what looks like DNS issues.
Can we override these to get changes to merge? |
|
/override ci/prow/e2e-aws-serial On going issue with the build cluster, I'm confident this won't be an issue for us |
|
@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/e2e-aws-serial, ci/prow/e2e-aws-serial-techpreview In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@vr4manta: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
[ART PR BUILD NOTIFIER] Distgit: ose-cluster-config-api |
SPLAT-2078
Changes
Dependencies