Skip to content

OPRUN-3780: Add feature flag for NewOLMPreflightPermissionCheck #2242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 8, 2025
Merged

OPRUN-3780: Add feature flag for NewOLMPreflightPermissionCheck #2242

merged 1 commit into from
Apr 8, 2025

Conversation

tmshort
Copy link
Contributor

@tmshort tmshort commented Mar 19, 2025

No description provided.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 19, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 19, 2025 •
edited by openshift-ci bot
Loading

@tmshort: This pull request references OPRUN-3780 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 19, 2025

Hello @tmshort! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 19, 2025
@tmshort tmshort force-pushed the preflight-checks branch 2 times, most recently from 41c6c1c to e52fd39 Compare March 20, 2025 13:53
@grokspawn
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 20, 2025
@tmshort
Copy link
Contributor Author

tmshort commented Mar 21, 2025

/retest-required

4 similar comments
@tmshort
Copy link
Contributor Author

tmshort commented Mar 21, 2025

/retest-required

@tmshort
Copy link
Contributor Author

tmshort commented Mar 24, 2025

/retest-required

@tmshort
Copy link
Contributor Author

tmshort commented Mar 25, 2025

/retest-required

@tmshort
Copy link
Contributor Author

tmshort commented Mar 26, 2025

/retest-required

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 27, 2025
@tmshort
Copy link
Contributor Author

tmshort commented Mar 28, 2025

/retest-required

@tmshort
Copy link
Contributor Author

tmshort commented Mar 31, 2025

@grokspawn can you tag this LGTM? I rebased.

@tmshort
Copy link
Contributor Author

tmshort commented Mar 31, 2025

@deads2k @derekwaynecarr looking for approval?

@grokspawn
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 31, 2025
@tmshort
Copy link
Contributor Author

tmshort commented Mar 31, 2025

/assign joelspeed

@tmshort
Copy link
Contributor Author

tmshort commented Apr 7, 2025

@JoelSpeed anything we need to get approval?

@JoelSpeed
Copy link
Contributor

/lgtm

No sorry, I hadn't had a chance to review the response to my previous question

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 7, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: grokspawn, JoelSpeed, tmshort

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 7, 2025
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 00e6260 and 2 for PR HEAD 607b001 in total

1 similar comment
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 00e6260 and 2 for PR HEAD 607b001 in total

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 8, 2025 •
edited
Loading

@tmshort: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn 607b001 link false /test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 00e6260 and 2 for PR HEAD 607b001 in total

@tmshort
Copy link
Contributor Author

tmshort commented Apr 8, 2025

Ugh... the e2e-aws-serial-techpreview test failed due to exceeding 4h? It received an interrupt signal during deprovisioning.

@openshift-merge-bot openshift-merge-bot bot merged commit 6fb534f into openshift:master Apr 8, 2025
22 of 23 checks passed
@tmshort tmshort deleted the preflight-checks branch April 8, 2025 18:10
perdasilva pushed a commit to perdasilva/api-1 that referenced this pull request Apr 8, 2025
@openshift-merge-bot
Merge pull request openshift#2242 from tmshort/preflight-checks
c66b807 
OPRUN-3780: Add feature flag for NewOLMPreflightPermissionCheck
Signed-off-by: Per Goncalves da Silva <[email protected]>
@grokspawn grokspawn mentioned this pull request Apr 8, 2025
Merged
@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

Distgit: ose-cluster-config-api
This PR has been included in build ose-cluster-config-api-container-v4.19.0-202504090015.p0.g6fb534f.assembly.stream.el9.
All builds following this will include this PR.

@jianzhangbjz jianzhangbjz mentioned this pull request Apr 17, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoelSpeed JoelSpeed JoelSpeed left review comments

@grokspawn grokspawn grokspawn left review comments

@deads2k deads2k Awaiting requested review from deads2k

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

Assignees

@JoelSpeed JoelSpeed

@grokspawn grokspawn

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tmshort @openshift-ci-robot @grokspawn @JoelSpeed @openshift-bot