Skip to content

OAPE-148: Promote CPMSMachineNamePrefix feature gate to default feature set #2254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 24, 2025
+54 −8
Merged

OAPE-148: Promote CPMSMachineNamePrefix feature gate to default feature set #2254

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion features.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@
| AWSClusterHostedDNS| | | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> |
| AutomatedEtcdBackup| | | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> |
| BootcNodeManagement| | | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> |
| CPMSMachineNamePrefix| | | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> |
| ClusterAPIInstallIBMCloud| | | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> |
| ClusterMonitoringConfig| | | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> |
| ConsolePluginContentSecurityPolicy| | | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> |
Expand Down Expand Up @@ -74,6 +73,7 @@
| AzureWorkloadIdentity| <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> |
| BareMetalLoadBalancer| <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> |
| BuildCSIVolumes| <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> |
| CPMSMachineNamePrefix| <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> |
| ChunkSizeMiB| <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> |
| CloudDualStackNodeIPs| <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> |
| DisableKubeletCloudCredentialProviders| <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> |
Expand Down
2 changes: 1 addition & 1 deletion features/features.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,7 +240,7 @@ var (
contactPerson("chiragkyal").
productScope(ocpSpecific).
enhancementPR("https://github.com/openshift/enhancements/pull/1714").
enableIn(configv1.DevPreviewNoUpgrade, configv1.TechPreviewNoUpgrade).
enableIn(configv1.Default, configv1.DevPreviewNoUpgrade, configv1.TechPreviewNoUpgrade).
mustRegister()

FeatureGateAdminNetworkPolicy = newFeatureGate("AdminNetworkPolicy").
Expand Down
23 changes: 23 additions & 0 deletions ...d-manifests/0000_10_control-plane-machine-set_01_controlplanemachinesets-Default.crd.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,29 @@ spec:
description: ControlPlaneMachineSet represents the configuration of the
ControlPlaneMachineSet.
properties:
machineNamePrefix:
description: |-
machineNamePrefix is the prefix used when creating machine names.
Each machine name will consist of this prefix, followed by
a randomly generated string of 5 characters, and the index of the machine.
It must be a lowercase RFC 1123 subdomain, consisting of lowercase
alphanumeric characters, hyphens ('-'), and periods ('.').
Each block, separated by periods, must start and end with an alphanumeric character.
Hyphens are not allowed at the start or end of a block, and consecutive periods are not permitted.
The prefix must be between 1 and 245 characters in length.
For example, if machineNamePrefix is set to 'control-plane',
and three machines are created, their names might be:
control-plane-abcde-0, control-plane-fghij-1, control-plane-klmno-2
maxLength: 245
minLength: 1
type: string
x-kubernetes-validations:
- message: a lowercase RFC 1123 subdomain must consist of lowercase
alphanumeric characters, hyphens ('-'), and periods ('.'). Each
block, separated by periods, must start and end with an alphanumeric
character. Hyphens are not allowed at the start or end of a block,
and consecutive periods are not permitted.
rule: '!format.dns1123Subdomain().validate(self).hasValue()'
replicas:
default: 3
description: |-
Expand Down
23 changes: 23 additions & 0 deletions ...ifests/crds/0000_10_control-plane-machine-set_01_controlplanemachinesets-Default.crd.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,29 @@ spec:
description: ControlPlaneMachineSet represents the configuration of the
ControlPlaneMachineSet.
properties:
machineNamePrefix:
description: |-
machineNamePrefix is the prefix used when creating machine names.
Each machine name will consist of this prefix, followed by
a randomly generated string of 5 characters, and the index of the machine.
It must be a lowercase RFC 1123 subdomain, consisting of lowercase
alphanumeric characters, hyphens ('-'), and periods ('.').
Each block, separated by periods, must start and end with an alphanumeric character.
Hyphens are not allowed at the start or end of a block, and consecutive periods are not permitted.
The prefix must be between 1 and 245 characters in length.
For example, if machineNamePrefix is set to 'control-plane',
and three machines are created, their names might be:
control-plane-abcde-0, control-plane-fghij-1, control-plane-klmno-2
maxLength: 245
minLength: 1
type: string
x-kubernetes-validations:
- message: a lowercase RFC 1123 subdomain must consist of lowercase
alphanumeric characters, hyphens ('-'), and periods ('.'). Each
block, separated by periods, must start and end with an alphanumeric
character. Hyphens are not allowed at the start or end of a block,
and consecutive periods are not permitted.
rule: '!format.dns1123Subdomain().validate(self).hasValue()'
replicas:
default: 3
description: |-
Expand Down
6 changes: 3 additions & 3 deletions payload-manifests/featuregates/featureGate-Hypershift-Default.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,6 @@
{
"name": "BootcNodeManagement"
},
{
"name": "CPMSMachineNamePrefix"
},
{
"name": "ClusterAPIInstall"
},
Expand Down Expand Up @@ -234,6 +231,9 @@
{
"name": "BuildCSIVolumes"
},
{
"name": "CPMSMachineNamePrefix"
},
{
"name": "ChunkSizeMiB"
},
Expand Down
6 changes: 3 additions & 3 deletions payload-manifests/featuregates/featureGate-SelfManagedHA-Default.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,6 @@
{
"name": "BootcNodeManagement"
},
{
"name": "CPMSMachineNamePrefix"
},
{
"name": "ClusterAPIInstall"
},
Expand Down Expand Up @@ -234,6 +231,9 @@
{
"name": "BuildCSIVolumes"
},
{
"name": "CPMSMachineNamePrefix"
},
{
"name": "ChunkSizeMiB"
},
Expand Down