Add ClusterResourceOverridesEnabled for console config #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/L
jwforres
reviewed
Jan 16, 2018
webconsole/v1/types.go
Outdated
| @@ -42,6 +42,10 @@ type ClusterInfo struct { | |||
| // LogoutPublicURL is an optional, absolute URL to redirect web browsers to after logging out of the web | |||
| // console. If not specified, the built-in logout page is shown. | |||
| LogoutPublicURL string `json:"logoutPublicURL" protobuf:"bytes,5,opt,name=logoutPublicURL"` | |||
|
|
|||
| // ClusterResourceOverridesEnabled indicates that the cluster is configured for overcommit and the web console | |||
| // should hide request and limit fields that will be overridden in its editors | |||
There was a problem hiding this comment.
Should we be more clear in this comment that we assume this means all cluster resource overrides are in use and all memory and cpu fields will be hidden except for the memory limit?
There was a problem hiding this comment.
Yeah I'll update it with more detail
|
Updated |
|
PR with console changes: openshift/origin-web-console#2671 |
|
@deads2k any objections? |
|
Updated |
|
LGTM |
|
Thanks. Will merge on green. |
This was referenced Jan 19, 2018
openshift-merge-robot
added a commit
to openshift/origin
that referenced
this pull request
Jan 23, 2018
Automatic merge from submit-queue. Add clusterResourceOverridesEnabled flag to console config template See openshift/api#32 /assign @jwforres /cc @deads2k
openshift-merge-robot
added a commit
to openshift/openshift-ansible
that referenced
this pull request
Jan 24, 2018
Automatic merge from submit-queue. Add clusterResourceOverridesEnabled to console config Adds clusterResourceOverridesEnabled flag to console install. See openshift/api#32 See openshift/origin#18231 /assign @sdodson /cc @jwforres
openshift-cherrypick-robot
pushed a commit
to openshift-cherrypick-robot/api
that referenced
this pull request
Feb 1, 2021
validation: bundle CRDs are compared by definition key instead of name
openshift-cherrypick-robot
pushed a commit
to openshift-cherrypick-robot/api
that referenced
this pull request
Feb 1, 2021
validation: bundle CRDs are compared by definition key instead of name (openshift#32)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We plan to have one flag in the console config that says whether ClusterResourceOverrides are enabled. The console will hide the CPU request, CPU limit, and memory request fields if the flag is true.
Regardless of whether the flag is set, we'll show if a value was changed using the annotation from openshift/origin#18007. If a deployment has pods with changed value, we can also show that on the deployment page.
/assign @deads2k
/cc @jwforres @smarterclayton