Add the 'as' field to ImageSource to allow multi-stage builds #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `as` field allows image sources to be used directly by multi-stage Docker builds to replace hardcoded strings in the Dockerfile with images delivered via image streams. After this change, both `paths` and `as` are optional as long as at least one is specified. The list of values in the `as` field are exact string replacements for fields in the Dockerfile.
openshift-ci-robot
added
the
size/XL
|
api looks reasonable. |
|
lgtm |
openshift-merge-robot
added a commit
to openshift/origin
that referenced
this pull request
Mar 9, 2018
Automatic merge from submit-queue (batch tested with PRs 18887, 18741). Support multi-stage dockerbuilds via imagebuilder Needs an e2e test and a way to perform replacement on the stage images. Will allow standard multi-stage Dockerfile builds against any Docker 1.12+ backend. API PR openshift/api#34
openshift-cherrypick-robot
pushed a commit
to openshift-cherrypick-robot/api
that referenced
this pull request
Feb 1, 2021
Update webhook description
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
asfield allows image sources to be used directly by multi-stageDocker builds to replace hardcoded strings in the Dockerfile with images
delivered via image streams. After this change, both
pathsandasare optional as long as at least one is specified. The list of values in
the
asfield are exact string replacements for fields in theDockerfile.
@bparees for discussion at minimum.
Part of openshift/origin#18741