Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove the service catalog crds #596

Merged
merged 4 commits into from
Mar 24, 2020
Merged

remove the service catalog crds #596

merged 4 commits into from
Mar 24, 2020

Conversation

jmrodri
Copy link
Contributor

@jmrodri jmrodri commented Mar 11, 2020

We are removing service catalog in OpenShift 4.5. We don't need the
CRDs. We are leaving the go types until 4.6.

@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 11, 2020
@jmrodri
Copy link
Contributor Author

jmrodri commented Mar 11, 2020

/assign @soltysh

@jmrodri
Copy link
Contributor Author

jmrodri commented Mar 11, 2020

@soltysh @shawn-hurley this is what we discussed via email

@jmrodri
Copy link
Contributor Author

jmrodri commented Mar 11, 2020

/assign @derekwaynecarr

@deads2k
Copy link
Contributor

deads2k commented Mar 12, 2020 •
edited
Loading

Can you link to the code in the 4.4 service-catalog operator that goes upgradeable==false if the operator is in managed state?

/hold

Once that is linked from 4.4 and @soltysh's comments are addressed, I'm ok releasing this hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 12, 2020
soltysh
soltysh suggested changes Mar 12, 2020
View reviewed changes
Copy link

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additionally, please update the go types to explicitly have DEPRECATED, will be removed in 4.6 in the comment so there are no doubts these types will be soon gone.

@soltysh
Copy link

soltysh commented Mar 12, 2020

For reference release notes deprecating this functionality in 4.1 https://docs.openshift.com/container-platform/4.1/release_notes/ocp-4-1-release-notes.html#ocp-4-1-notable-technical-changes

@jmrodri
Copy link
Contributor Author

jmrodri commented Mar 13, 2020

@deads2k thanks for that reminder, it looks like it didn't get into 4.4 to set Upgradeable to False. I have two PRs up to add that:
cluster-svcat-apiserver-operator: openshift/cluster-svcat-apiserver-operator#78
cluster-svcat-controller-manager-operator: openshift/cluster-svcat-controller-manager-operator#72

jmrodri added 2 commits March 23, 2020 12:00
@jmrodri
remove the service catalog crds
cc711f1 
We are removing service catalog in OpenShift 4.5. We don't need the
CRDs. We are leaving the go types until 4.6.
@jmrodri
mark service catalog types DEPRECATED
49cc721
@jmrodri
Copy link
Contributor Author

jmrodri commented Mar 23, 2020

/retest

@jmrodri jmrodri force-pushed the remove-service-catalog branch from 6e7e306 to 49cc721 Compare March 23, 2020 18:09
@jmrodri
Copy link
Contributor Author

jmrodri commented Mar 24, 2020

The PRs in this comment have merged: #596 (comment)

soltysh
soltysh approved these changes Mar 24, 2020
View reviewed changes
Copy link

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All is good and the linked PRs look legit.
/hold cancel
/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Mar 24, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jmrodri, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 24, 2020
@openshift-merge-robot openshift-merge-robot merged commit 9b3bdf8 into openshift:master Mar 24, 2020
@jmrodri jmrodri deleted the remove-service-catalog branch March 24, 2020 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soltysh soltysh soltysh approved these changes

@abhinavdahiya abhinavdahiya Awaiting requested review from abhinavdahiya

@adambkaplan adambkaplan Awaiting requested review from adambkaplan

Assignees

@soltysh soltysh

@derekwaynecarr derekwaynecarr

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jmrodri @deads2k @soltysh @openshift-ci-robot @derekwaynecarr @openshift-merge-robot