Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ACM-19143: align default osImages for 2.13 with supported-ocp-versions #7469

Open
wants to merge 2 commits into
base: release-ocm-2.13
Choose a base branch
from

Conversation

zszabo-rh
Copy link
Contributor

@zszabo-rh zszabo-rh commented Mar 27, 2025

ACM-19143: default osImages versions should be taken from supported-ocp-versions.json
Pls note that corresponding backplane version is 5 versions behind release-ocm version.

Commits:

  1. Main changes: data/default_os_images.json was modified, all other changes were generated.
  2. Necessary unit and subsystem tst modifications.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 27, 2025

@zszabo-rh: This pull request references ACM-19143 which is a valid jira issue.

In response to this:

ACM-19143: default osImages versions should be taken from supported-ocp-versions.json
Pls note that corresponding backplane version is 5 versions behind release-ocm version.

data/default_os_images.json was modified, all other changes were generated.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 27, 2025
@openshift-ci openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 27, 2025
@openshift-ci openshift-ci bot requested review from gamli75 and rccrdpccl March 27, 2025 10:03
Copy link

openshift-ci bot commented Mar 27, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: zszabo-rh
Once this PR has been reviewed and has the lgtm label, please assign romfreiman for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zszabo-rh
Copy link
Contributor Author

/retest

1 similar comment
@zszabo-rh
Copy link
Contributor Author

/retest

Copy link

codecov bot commented Mar 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.97%. Comparing base (c681db7) to head (9a543bc).
Report is 4 commits behind head on release-ocm-2.13.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##           release-ocm-2.13    #7469   +/-   ##
=================================================
  Coverage             67.97%   67.97%           
=================================================
  Files                   300      300           
  Lines                 41007    41031   +24     
=================================================
+ Hits                  27873    27891   +18     
- Misses                10632    10635    +3     
- Partials               2502     2505    +3     

see 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@zszabo-rh
Copy link
Contributor Author

/retest

2 similar comments
@zszabo-rh
Copy link
Contributor Author

/retest

@zszabo-rh
Copy link
Contributor Author

/retest

@zszabo-rh zszabo-rh force-pushed the release-ocm-2.13 branch 2 times, most recently from 388fb4c to ff4df3e Compare March 28, 2025 13:25
@openshift-ci openshift-ci bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 28, 2025
@zszabo-rh zszabo-rh force-pushed the release-ocm-2.13 branch 3 times, most recently from 31b8b47 to 813e83c Compare March 31, 2025 11:02
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 1, 2025

@zszabo-rh: This pull request references ACM-19143 which is a valid jira issue.

In response to this:

ACM-19143: default osImages versions should be taken from supported-ocp-versions.json
Pls note that corresponding backplane version is 5 versions behind release-ocm version.

Commits:

  1. Main changes: data/default_os_images.json was modified, all other changes were generated.
  2. Necessary unit and subsystem tst modifications.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Apr 1, 2025
@openshift-ci openshift-ci bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 1, 2025
@zszabo-rh zszabo-rh force-pushed the release-ocm-2.13 branch 3 times, most recently from 21ade0e to 681ca03 Compare April 3, 2025 03:44
@zszabo-rh zszabo-rh force-pushed the release-ocm-2.13 branch 3 times, most recently from 69cf9a4 to 0bf1c6b Compare April 4, 2025 07:48
Copy link

openshift-ci bot commented Apr 4, 2025

@zszabo-rh: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/subsystem-aws 9a543bc link true /test subsystem-aws

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants