Fix static IPs config option and use a new name #1099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
do-not-merge/hold
YuviGold
reviewed
Sep 9, 2021
discovery-infra/test_infra/utils/global_variables/env_variables_utils.py
Outdated
Show resolved
Hide resolved
osherdp
force-pushed
the
fix/static-ips-parameter
branch
from
0c3f0af to
d606c18
Compare
YuviGold
approved these changes
Sep 9, 2021
openshift-ci
bot
added
size/S
|
It's still not fixing it all, need to keep working on the fix |
openshift-ci
bot
changed the title
openshift-ci
bot
added
the
do-not-merge/work-in-progress
osherdp
force-pushed
the
fix/static-ips-parameter
branch
from
d606c18 to
8d2b70d
Compare
openshift-ci
bot
added
size/M
|
/retitle Fix static IPs config option and use a new name |
openshift-ci
bot
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
YuviGold
approved these changes
Sep 9, 2021
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: osherdp, YuviGold The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/unhold |
openshift-ci
bot
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed
IS_STATIC_IPconfiguration option, and changed its name to justSTATIC_IPS.Seems like
static_network_configoption not delivered toprepare_for_installationso that we always just configured dynamic networking.Also, we only gather IPs via DHCP server, although libvirt is capable to get it via ARP (which is useful for static IPs).
/cc @eliorerz @YuviGold
/hold