Code cleanups from #547

[smarthall]

What type of PR is this?

cleanup

What this PR does / Why we need it?

This code removes some unused code, and cleans up some duplicated code paths.

Which Jira/Github issue(s) does this PR fix?

N/A

(was done as part of https://issues.redhat.com/browse/OSD-19766)

Special notes for your reviewer

Unit Test Coverage

Guidelines

• If it's a new sub-command or new function to an existing sub-command, please cover at least 50% of the code
• If it's a bug fix for an existing sub-command, please cover 70% of the code

Test coverage checks

• Added unit tests
• Created jira card to add unit test
• This PR may not need unit tests

Pre-checks (if applicable)

• Ran unit tests locally
• Validated the changes in a cluster
• Included documentation changes with PR

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 0% with 16 lines in your changes missing coverage. Please review.

Project coverage is 45.83%. Comparing base (594bdf0) to head (f3f3513).
Report is 4 commits behind head on main.

Files with missing lines	Patch %	Lines
pkg/backplaneapi/clientUtils.go	0.00%	16 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #552      +/-   ##
==========================================
+ Coverage   45.73%   45.83%   +0.10%     
==========================================
  Files          82       82              
  Lines        6236     6222      -14     
==========================================
  Hits         2852     2852              
+ Misses       3030     3017      -13     
+ Partials      354      353       -1     

Files with missing lines	Coverage Δ
cmd/ocm-backplane/managedJob/getManagedJob.go	68.25% <ø> (+2.10%)	⬆️
pkg/backplaneapi/clientUtils.go	0.00% <0.00%> (ø)

[bmeng]

The #547 has not been merged? I think we can make changes directly there?

[smarthall]

@bmeng I split the change into two PRs because @samanthajayasinghe suggested that the new features should be one and the code cleanup should be another.

[bmeng]

/label tide/merge-method-squash
/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bmeng, smarthall

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [bmeng]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@smarthall: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.