Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumping gingko to v2 from v1 #656

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

MitaliBhalla
Copy link
Contributor

@MitaliBhalla MitaliBhalla commented Apr 2, 2025

What type of PR is this?

  • Bug
  • Feature
  • Documentation
  • Test Coverage
  • Clean Up
  • Others

What this PR does / Why we need it?

This pull request updates the backplane-cli by upgrading the Ginkgo testing framework from version 1 to version 2. This involves:​

  1. Modifying test files to align with Ginkgo v2's updated syntax and structure.​

  2. Updating the go.mod and go.sum files to reference the new Ginkgo v2 module.​

These updates ensure compatibility with Ginkgo v2's features and improvements, including unblocking of the use of OCM testing modules which was not possible in v1

Which Jira/Github issue(s) does this PR fix?

OSD-28786

  • Related Issue #
  • Closes #

OSD-28786

Special notes for your reviewer

Unit Test Coverage

Guidelines

  • If it's a new sub-command or new function to an existing sub-command, please cover at least 50% of the code
  • If it's a bug fix for an existing sub-command, please cover 70% of the code

Test coverage checks

  • Added unit tests
  • Created jira card to add unit test
  • This PR may not need unit tests

Pre-checks (if applicable)

  • Ran unit tests locally
  • Validated the changes in a cluster
  • Included documentation changes with PR

@openshift-ci openshift-ci bot requested review from smarthall and Tafhim April 2, 2025 04:52
Copy link
Contributor

openshift-ci bot commented Apr 2, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MitaliBhalla

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 2, 2025
fixing tests

Fixing dependencies

Update and fix test errors
@MitaliBhalla
Copy link
Contributor Author

The tests are passing locally. A bit more deep dive would be needed to understand why are there issues in the CI build tests.

Copy link
Contributor

openshift-ci bot commented Apr 3, 2025

@MitaliBhalla: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/test a1ef3f0 link true /test test
ci/prow/coverage a1ef3f0 link true /test coverage

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant