Change builder image #35
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
do-not-merge/hold
littlejawa
removed
the
do-not-merge/hold
littlejawa
force-pushed
the
change_go_builder_image
branch
from
b689dcf to
dcdfc30
Compare
This was added by mistake - needed for local build, but not in the repo. It doesn't break the build as Konflux actually sets this same folder by itself, but it should not be left by default. Signed-off-by: Julien Ropé <[email protected]>
littlejawa
force-pushed
the
change_go_builder_image
branch
2 times, most recently
from
f61f21e to
86eb2cf
Compare
…pstream Rather than hardcoding the values we need in the Dockerfile, use build environment variables to pass the parameters during build. This reduces the differences with upstream's Dockerfile, and should ease its maintenance. Signed-off-by: Julien Ropé <[email protected]>
Use golang 1.23 from openshift builder images. Signed-off-by: Julien Ropé <[email protected]>
Our builder image uses a wrapper script on top of the go binary. This wrapper is not keeping the quotes as they are set in the Makefile, making the resulting parameters to the 'go' command miss a closing quote. This commit fixes it by removing quotes in the GOFLAGS variable in the Makefile. Signed-off-by: Julien Ropé <[email protected]>
littlejawa
force-pushed
the
change_go_builder_image
branch
from
86eb2cf to
42d300e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use golang 1.23 from openshift builder images.
Bringing the konflux build to the same level as our downstream CPaaS builds.
Changing the builder image first, as it seems to cause build issues.