OCPBUGS-51818: Bump golang x/crypto to fix CVE-2025-22869

[aman4433]

A flaw was found in golang.org/x/crypto.
SSH servers which implement file transfer protocols are vulnerable to a denial of service attack from clients which complete the key exchange slowly, or not at all, causing pending content to be read into memory, but never transmitted.

To address this issue, we have upgraded the library to version v0.35.0, which includes a fix for the vulnerability.

Affected Library: golang.org/x/crypto
Current Version: v0.19.0
Fixed Version: v0.35.0

[openshift-ci-robot]

@aman4433: This pull request references Jira Issue OCPBUGS-51818, which is invalid:

• release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
• expected Jira Issue OCPBUGS-51818 to depend on a bug targeting a version in 4.17.0, 4.17.z and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

A flaw was found in golang.org/x/crypto.
SSH servers which implement file transfer protocols are vulnerable to a denial of service attack from clients which complete the key exchange slowly, or not at all, causing pending content to be read into memory, but never transmitted.

To address this issue, we have upgraded the library to version v0.35.0, which includes a fix for the vulnerability.

Affected Library: golang.org/x/crypto
Current Version: v0.19.0
Fixed Version: v0.35.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

Hi @aman4433. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign radekmanak for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[Karthik-K-N]

Is it required to update the go version to fix the CVE?

[aman4433]

Yes, running go mod tidy updated Go from version 1.20 to 1.23.0.

[damdo]

Unfortunately we can't do this
There have been lengthy discussions on this internally in the org.
See: https://redhat-internal.slack.com/archives/CE4UC6AVB/p1741170208238289

[damdo]

/hold

For changes to the go.mod

[Karthik-K-N]

@damdo How should we deal with this CVE fix?