Skip to content

OCPBUGS-23435: bump library-go to bring in workload-conditions fix #739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

atiratree
Copy link
Member

@atiratree atiratree commented Nov 12, 2024

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 12, 2024
@openshift-ci openshift-ci bot requested review from ibihim and liouk November 12, 2024 12:36
@atiratree atiratree force-pushed the workload-conditions-bump branch from a05d0cb to f2ea443 Compare November 20, 2024 16:41
@atiratree atiratree changed the title [WIP] bump library-go to bring in workload-conditions fix bump library-go to bring in workload-conditions fix Nov 20, 2024
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 20, 2024
@atiratree atiratree changed the title bump library-go to bring in workload-conditions fix OCPBUGS-23435: bump library-go to bring in workload-conditions fix Nov 20, 2024
@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Nov 20, 2024
@openshift-ci-robot
Copy link
Contributor

@atiratree: This pull request references Jira Issue OCPBUGS-23435, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

bring in openshift/library-go#1855

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@atiratree atiratree force-pushed the workload-conditions-bump branch from f2ea443 to 7009bfa Compare November 20, 2024 16:50
@atiratree
Copy link
Member Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Nov 20, 2024
@openshift-ci-robot
Copy link
Contributor

@atiratree: This pull request references Jira Issue OCPBUGS-23435, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.18.0) matches configured target version for branch (4.18.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @xingxingxia

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Nov 20, 2024
@openshift-ci openshift-ci bot requested a review from xingxingxia November 20, 2024 16:51
@atiratree atiratree force-pushed the workload-conditions-bump branch from 7009bfa to 4fe1d07 Compare November 20, 2024 17:52
@atiratree
Copy link
Member Author

/retest

@liouk
Copy link
Member

liouk commented Nov 21, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 21, 2024
@deads2k
Copy link
Contributor

deads2k commented Nov 21, 2024

/approve

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 21, 2024
@atiratree atiratree force-pushed the workload-conditions-bump branch from 4fe1d07 to 32069a6 Compare November 22, 2024 11:53
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 22, 2024
@deads2k
Copy link
Contributor

deads2k commented Nov 22, 2024

/lgtm

Copy link
Contributor

openshift-ci bot commented Nov 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: atiratree, deads2k, liouk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 22, 2024
@atiratree
Copy link
Member Author

/test e2e-agnostic-upgrade

Copy link
Contributor

openshift-ci bot commented Nov 22, 2024

@atiratree: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn 32069a6 link false /test okd-scos-e2e-aws-ovn
ci/prow/test-operator-integration 32069a6 link false /test test-operator-integration

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 75c7842 into openshift:master Nov 25, 2024
14 of 16 checks passed
@openshift-ci-robot
Copy link
Contributor

@atiratree: Jira Issue OCPBUGS-23435: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-23435 has not been moved to the MODIFIED state.

In response to this:

bring in openshift/library-go#1855

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: ose-cluster-authentication-operator
This PR has been included in build ose-cluster-authentication-operator-container-v4.19.0-202411251539.p0.g75c7842.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants