Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: OCPCLOUD-2564: add migration controllers #268

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

WIP: OCPCLOUD-2564: add migration controllers #268

wants to merge 3 commits into from

Conversation

damdo
Copy link
Member

@damdo damdo commented Mar 7, 2025 •
edited
Loading

TODO:

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 7, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 7, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@damdo damdo changed the title WIP: machinesetmigration: add controller WIP: OCPCLOUD-2564: machinesetmigration: add controller Mar 10, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 10, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 10, 2025 •
edited by openshift-ci bot
Loading

@damdo: This pull request references OCPCLOUD-2564 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@damdo damdo force-pushed the add-machineset-migration-controller branch 2 times, most recently from 5f8b832 to b5552ee Compare March 13, 2025 11:29
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 13, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign nrb for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@damdo damdo force-pushed the add-machineset-migration-controller branch 2 times, most recently from 9b61798 to 3759a54 Compare March 13, 2025 17:39
JoelSpeed
JoelSpeed reviewed Mar 14, 2025
View reviewed changes
Copy link
Contributor

@JoelSpeed JoelSpeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looked at this only from a high level at the moment, broad strokes this is what I'm expecting to be implemented, need to check the finalizers behaviour though as I don't think it's currently what I had in mind for this controller re finalizer involvement

@damdo damdo force-pushed the add-machineset-migration-controller branch from bc0385b to 6347c6d Compare April 1, 2025 16:48
@damdo damdo changed the title WIP: OCPCLOUD-2564: machinesetmigration: add controller WIP: OCPCLOUD-2564: add migration controllers Apr 1, 2025
@damdo damdo force-pushed the add-machineset-migration-controller branch 2 times, most recently from a0ebc56 to 0f07912 Compare April 4, 2025 13:09
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 4, 2025 •
edited by openshift-ci bot
Loading

@damdo: This pull request references OCPCLOUD-2564 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

TODO:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@damdo damdo force-pushed the add-machineset-migration-controller branch 2 times, most recently from 2273e6a to feb216e Compare April 8, 2025 07:34
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 8, 2025 •
edited by openshift-ci bot
Loading

@damdo: This pull request references OCPCLOUD-2564 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

TODO:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 8, 2025 •
edited by openshift-ci bot
Loading

@damdo: This pull request references OCPCLOUD-2564 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

TODO:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@damdo damdo mentioned this pull request Apr 8, 2025
Merged
JoelSpeed
JoelSpeed reviewed Apr 9, 2025
View reviewed changes
pkg/controllers/machinemigration/machine_migration_controller.go Outdated
if cond, err := util.GetConditionStatus(mapiMachine, string(consts.SynchronizedCondition)); err != nil {
return ctrl.Result{}, fmt.Errorf("unable to get synchronizedCondition for %s/%s: %w", mapiMachine.Namespace, mapiMachine.Name, err)
} else if cond != corev1.ConditionTrue {
logger.Info("New machine not yet in sync with the old authoritative one, will retry later")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this log the correct phrasing, new machine maybe isn't correct?

Maybe more like

Machine is not synchronized with latest generation

It is the old authoritative that must sync to the new authoritative before we switch over, not vice versa

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here old authoritative refers to the currently authoritative one and "new" means to-be authoritative.
The latter needs to be in-sync with the former for us to continue migrating.

I know the wording is confusing, I am improving it.

@damdo damdo force-pushed the add-machineset-migration-controller branch from feb216e to add7c0d Compare April 10, 2025 15:50
@damdo damdo force-pushed the add-machineset-migration-controller branch from add7c0d to e45c05f Compare April 11, 2025 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoelSpeed JoelSpeed JoelSpeed left review comments

Assignees
No one assigned
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@damdo @openshift-ci-robot @JoelSpeed