-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-48481: annotation validation policy #379
Conversation
5b33c11
to
2298e65
Compare
Validated for gcp , looks good , yet to check on azure cluster . |
@miyadav: This pull request references Jira Issue OCPBUGS-48481, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/jira refresh |
@miyadav: This pull request references Jira Issue OCPBUGS-48481, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/jira refresh |
@miyadav: This pull request references Jira Issue OCPBUGS-48481, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: miyadav. Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
validated for azure as well. |
pkg/cloud/azure/assets/validating-admission-service-annotation-policy.yaml
Outdated
Show resolved
Hide resolved
@miyadav: This pull request references Jira Issue OCPBUGS-48481, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: miyadav. Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/jira refresh |
@miyadav: This pull request references Jira Issue OCPBUGS-48481, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/retest-required |
2 similar comments
@miyadav Can you take a look at the failing units? They look as though they could be legitimate issues |
/retest-required |
azure-load-balancer-tcp-idle-timeout validation for svc optimized as per reviews
@miyadav: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/lgtm |
a4f2374
into
openshift:master
@miyadav: Jira Issue OCPBUGS-48481: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-48481 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
[ART PR BUILD NOTIFIER] Distgit: ose-cluster-cloud-controller-manager-operator |
/label qe-approved |
@miyadav: Jira Issue OCPBUGS-48481 is in an unrecognized state (MODIFIED) and will not be moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/jira refresh |
@miyadav: Jira Issue OCPBUGS-48481 is in an unrecognized state (MODIFIED) and will not be moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
if the annotation
cloud.google.com/network-tier
was used in service resource and it is left without value or incorrect value(say xyz) , the service goes toPending
status with only warningWarning SyncLoadBalancerFailed 1s (x3 over 17s) service-controller Error syncing load balancer: failed to ensure load balancer: unsupported network tier: "xyz"
, to avoid that , added the VAP .