Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-48481: annotation validation policy #379

Merged
merged 3 commits into from
Feb 24, 2025

Conversation

miyadav
Copy link
Member

@miyadav miyadav commented Jan 22, 2025

if the annotation cloud.google.com/network-tier was used in service resource and it is left without value or incorrect value(say xyz) , the service goes to Pending status with only warning
Warning SyncLoadBalancerFailed 1s (x3 over 17s) service-controller Error syncing load balancer: failed to ensure load balancer: unsupported network tier: "xyz"
, to avoid that , added the VAP .

@miyadav miyadav marked this pull request as draft January 22, 2025 05:46
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 22, 2025
@miyadav miyadav force-pushed the OCPBUG48481 branch 4 times, most recently from 5b33c11 to 2298e65 Compare January 23, 2025 04:59
@miyadav
Copy link
Member Author

miyadav commented Jan 23, 2025

Validated for gcp , looks good , yet to check on azure cluster .

@miyadav miyadav marked this pull request as ready for review January 23, 2025 07:12
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 23, 2025
@openshift-ci openshift-ci bot requested a review from sub-mod January 23, 2025 07:13
@miyadav miyadav changed the title OCPBUGS-48481 annotation validation policy OCPBUGS-48481: annotation validation policy Jan 23, 2025
@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jan 23, 2025
@openshift-ci-robot
Copy link

@miyadav: This pull request references Jira Issue OCPBUGS-48481, which is invalid:

  • expected the bug to target the "4.19.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

if the annotation cloud.google.com/network-tier was used in service resource and it is left without value or incorrect value(say xyz) , the service goes to Pending status with only warning
Warning SyncLoadBalancerFailed 1s (x3 over 17s) service-controller Error syncing load balancer: failed to ensure load balancer: unsupported network tier: "xyz"
, to avoid that , added the VAP .

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@miyadav
Copy link
Member Author

miyadav commented Jan 23, 2025

/jira refresh

@openshift-ci-robot
Copy link

@miyadav: This pull request references Jira Issue OCPBUGS-48481, which is invalid:

  • expected the bug to target the "4.19.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@miyadav
Copy link
Member Author

miyadav commented Jan 23, 2025

/jira refresh

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Jan 23, 2025
@openshift-ci-robot
Copy link

@miyadav: This pull request references Jira Issue OCPBUGS-48481, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.0) matches configured target version for branch (4.19.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @miyadav

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Jan 23, 2025
Copy link
Contributor

openshift-ci bot commented Jan 23, 2025

@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: miyadav.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

@miyadav: This pull request references Jira Issue OCPBUGS-48481, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.0) matches configured target version for branch (4.19.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @miyadav

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@miyadav
Copy link
Member Author

miyadav commented Jan 23, 2025

validated for azure as well.

@openshift-ci-robot
Copy link

@miyadav: This pull request references Jira Issue OCPBUGS-48481, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.0) matches configured target version for branch (4.19.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @miyadav

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

openshift-ci bot commented Feb 5, 2025

@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: miyadav.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

@miyadav: This pull request references Jira Issue OCPBUGS-48481, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.0) matches configured target version for branch (4.19.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @miyadav

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@miyadav
Copy link
Member Author

miyadav commented Feb 5, 2025

/jira refresh

@openshift-ci-robot
Copy link

@miyadav: This pull request references Jira Issue OCPBUGS-48481, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.0) matches configured target version for branch (4.19.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sunzhaohua2

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from sunzhaohua2 February 5, 2025 05:00
@sunzhaohua2
Copy link
Contributor

/retest-required

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 84ac6e4 and 2 for PR HEAD a637b1f in total

2 similar comments
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 84ac6e4 and 2 for PR HEAD a637b1f in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 84ac6e4 and 2 for PR HEAD a637b1f in total

@JoelSpeed
Copy link
Contributor

@miyadav Can you take a look at the failing units? They look as though they could be legitimate issues

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 84ac6e4 and 2 for PR HEAD a637b1f in total

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 21, 2025
@miyadav
Copy link
Member Author

miyadav commented Feb 21, 2025

/retest-required

Copy link
Contributor

openshift-ci bot commented Feb 21, 2025

@miyadav: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn b93ed3c link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-vsphere-ovn b93ed3c link false /test e2e-vsphere-ovn
ci/prow/e2e-openstack-ovn b93ed3c link false /test e2e-openstack-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@miyadav miyadav requested a review from JoelSpeed February 24, 2025 02:41
@JoelSpeed
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 24, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit a4f2374 into openshift:master Feb 24, 2025
15 of 18 checks passed
@openshift-ci-robot
Copy link

@miyadav: Jira Issue OCPBUGS-48481: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-48481 has been moved to the MODIFIED state.

In response to this:

if the annotation cloud.google.com/network-tier was used in service resource and it is left without value or incorrect value(say xyz) , the service goes to Pending status with only warning
Warning SyncLoadBalancerFailed 1s (x3 over 17s) service-controller Error syncing load balancer: failed to ensure load balancer: unsupported network tier: "xyz"
, to avoid that , added the VAP .

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

Distgit: ose-cluster-cloud-controller-manager-operator
This PR has been included in build ose-cluster-cloud-controller-manager-operator-container-v4.19.0-202502241207.p0.ga4f2374.assembly.stream.el9.
All builds following this will include this PR.

@miyadav
Copy link
Member Author

miyadav commented Feb 27, 2025

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Feb 27, 2025
@openshift-ci-robot
Copy link

@miyadav: Jira Issue OCPBUGS-48481 is in an unrecognized state (MODIFIED) and will not be moved to the MODIFIED state.

In response to this:

if the annotation cloud.google.com/network-tier was used in service resource and it is left without value or incorrect value(say xyz) , the service goes to Pending status with only warning
Warning SyncLoadBalancerFailed 1s (x3 over 17s) service-controller Error syncing load balancer: failed to ensure load balancer: unsupported network tier: "xyz"
, to avoid that , added the VAP .

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@miyadav miyadav deleted the OCPBUG48481 branch February 27, 2025 10:05
@miyadav
Copy link
Member Author

miyadav commented Feb 27, 2025

/jira refresh

@openshift-ci-robot
Copy link

@miyadav: Jira Issue OCPBUGS-48481 is in an unrecognized state (MODIFIED) and will not be moved to the MODIFIED state.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants