Skip to content

STOR-2017: Bump all deps for 4.18 #218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 19, 2024
Merged

STOR-2017: Bump all deps for 4.18 #218

merged 3 commits into from
Nov 19, 2024

Conversation

rhrmo
Copy link
Contributor

@rhrmo rhrmo commented Oct 23, 2024 •
edited
Loading

Bump all deps for 4.18

Notes:

  • Updated calls for functions coming from library-go
  • Added spec.unhealthyEvictionPolicy: AlwaysAllow to all pdbs

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 23, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 23, 2024 •
edited by openshift-ci bot
Loading

@rhrmo: This pull request references STOR-2017 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

Bump all deps for 4.18

Notes:

  • Updated calls for functions coming from library-go

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from dobsonj and RomanBednar October 23, 2024 13:25
@rhrmo
Copy link
Contributor Author

rhrmo commented Oct 23, 2024

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 23, 2024
@rhrmo
Copy link
Contributor Author

rhrmo commented Oct 24, 2024

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 24, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 24, 2024 •
edited by openshift-ci bot
Loading

@rhrmo: This pull request references STOR-2017 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

Bump all deps for 4.18

Notes:

  • Updated calls for functions coming from library-go
  • Added spec.unhealthyEvictionPolicy: AlwaysAllow to all pdbs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@rhrmo
Copy link
Contributor Author

rhrmo commented Nov 4, 2024

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 4, 2024
@rhrmo
Copy link
Contributor Author

rhrmo commented Nov 4, 2024

/test e2e-aws

@rhrmo
Copy link
Contributor Author

rhrmo commented Nov 4, 2024

/test images

jsafrane
jsafrane reviewed Nov 5, 2024
View reviewed changes
@rhrmo rhrmo force-pushed the STOR-2017-origin-master branch from 75814b1 to 2700978 Compare November 5, 2024 12:46
@rhrmo
Copy link
Contributor Author

rhrmo commented Nov 6, 2024

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 6, 2024
@rhrmo
Copy link
Contributor Author

rhrmo commented Nov 8, 2024

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 8, 2024
@rhrmo rhrmo force-pushed the STOR-2017-origin-master branch from caae904 to f160654 Compare November 8, 2024 09:36
@rhrmo
Copy link
Contributor Author

rhrmo commented Nov 8, 2024

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 8, 2024
@rhrmo
Copy link
Contributor Author

rhrmo commented Nov 8, 2024

/test e2e-vsphere

1 similar comment
@rhrmo
Copy link
Contributor Author

rhrmo commented Nov 8, 2024

/test e2e-vsphere

@rhrmo
Copy link
Contributor Author

rhrmo commented Nov 14, 2024

/retest-required

mpatlasov
mpatlasov reviewed Nov 14, 2024
View reviewed changes
mpatlasov
mpatlasov reviewed Nov 14, 2024
View reviewed changes
mpatlasov
mpatlasov reviewed Nov 14, 2024
View reviewed changes
mpatlasov
mpatlasov reviewed Nov 14, 2024
View reviewed changes
mpatlasov
mpatlasov reviewed Nov 14, 2024
View reviewed changes
mpatlasov
mpatlasov reviewed Nov 14, 2024
View reviewed changes
@rhrmo rhrmo force-pushed the STOR-2017-origin-master branch from f160654 to 7fcc8ec Compare November 15, 2024 09:19
mpatlasov
mpatlasov reviewed Nov 15, 2024
View reviewed changes
@rhrmo rhrmo force-pushed the STOR-2017-origin-master branch from 7fcc8ec to 6107247 Compare November 18, 2024 08:35
@mpatlasov
Copy link
Contributor

/lgtm
/approve
/label docs-approved
/label px-approved

@openshift-ci openshift-ci bot added docs-approved Signifies that Docs has signed off on this PR px-approved Signifies that Product Support has signed off on this PR labels Nov 18, 2024
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 18, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mpatlasov, rhrmo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 18, 2024
@rhrmo
Copy link
Contributor Author

rhrmo commented Nov 19, 2024

/retest

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 19, 2024

@rhrmo: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn 6107247 link false /test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@Phaow
Copy link
Contributor

Phaow commented Nov 19, 2024

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Nov 19, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 19, 2024 •
edited by openshift-ci bot
Loading

@rhrmo: This pull request references STOR-2017 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

Bump all deps for 4.18

Notes:

  • Updated calls for functions coming from library-go
  • Added spec.unhealthyEvictionPolicy: AlwaysAllow to all pdbs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-bot openshift-merge-bot bot merged commit 42ed4cc into openshift:master Nov 19, 2024
12 of 13 checks passed
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: ose-cluster-csi-snapshot-controller-operator
This PR has been included in build ose-cluster-csi-snapshot-controller-operator-container-v4.19.0-202411191537.p0.g42ed4cc.assembly.stream.el9.
All builds following this will include this PR.

@rhrmo
Copy link
Contributor Author

rhrmo commented Nov 21, 2024

/payload-job periodic-ci-openshift-release-master-ci-4.18-e2e-aws-ovn-upgrade

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 21, 2024

@rhrmo: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-ci-4.18-e2e-aws-ovn-upgrade

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/96a47a20-a7dc-11ef-8267-ef87107c02a1-0

@rhrmo
Copy link
Contributor Author

rhrmo commented Nov 21, 2024

/payload-job periodic-ci-openshift-release-master-ci-4.18-upgrade-from-stable-4.17-e2e-gcp-ovn-rt-upgrade

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 21, 2024

@rhrmo: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-ci-4.18-upgrade-from-stable-4.17-e2e-gcp-ovn-rt-upgrade

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/b4da13d0-a7fd-11ef-9e28-e047273a32cb-0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsafrane jsafrane jsafrane left review comments

@mpatlasov mpatlasov mpatlasov left review comments

@dobsonj dobsonj Awaiting requested review from dobsonj

@RomanBednar RomanBednar Awaiting requested review from RomanBednar

Assignees

@mpatlasov mpatlasov

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. docs-approved Signifies that Docs has signed off on this PR jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@rhrmo @openshift-ci-robot @mpatlasov @Phaow @openshift-bot @jsafrane