Skip to content

OCPBUGS-45073: Support HCP labels #223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

muraee
Copy link
Contributor

@muraee muraee commented Jan 8, 2025

HCP is adding a new API field to allow users creating HCP clusters to set custom labels on all HCP pods openshift/hypershift#5114. cluster-csi-snapshot-controller-operator needs to integrate this feature in the same way it integrated the NodeSelector feature for HCP.

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jan 8, 2025
@openshift-ci-robot
Copy link
Contributor

@muraee: This pull request references Jira Issue OCPBUGS-45073, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

HCP is adding a new API field to allow users creating HCP clusters to set custom labels on all HCP pods openshift/hypershift#5114. cluster-csi-snapshot-controller-operator needs to integrate this feature in the same way it integrated the NodeSelector feature for HCP.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@muraee
Copy link
Contributor Author

muraee commented Jan 8, 2025

cc @jsafrane

@openshift-ci openshift-ci bot requested review from bertinatto and mpatlasov January 8, 2025 16:40
@muraee
Copy link
Contributor Author

muraee commented Jan 8, 2025

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jan 8, 2025
@openshift-ci-robot
Copy link
Contributor

@muraee: This pull request references Jira Issue OCPBUGS-45073, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.0) matches configured target version for branch (4.19.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @ropatil010

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from ropatil010 January 8, 2025 16:40
@ropatil010
Copy link

/retest

@jsafrane
Copy link
Contributor

/retest-required

@jsafrane
Copy link
Contributor

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 15, 2025
Copy link
Contributor

openshift-ci bot commented Jan 15, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane, muraee

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 15, 2025
@muraee
Copy link
Contributor Author

muraee commented Jan 16, 2025

/label acknowledge-critical-fixes-only

@openshift-ci openshift-ci bot added the acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. label Jan 16, 2025
@muraee
Copy link
Contributor Author

muraee commented Jan 16, 2025

/retest-required

Copy link
Contributor

openshift-ci bot commented Jan 16, 2025

@muraee: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn 0878bc0 link false /test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@muraee
Copy link
Contributor Author

muraee commented Jan 16, 2025

/retest-required

@openshift-merge-bot openshift-merge-bot bot merged commit a68ffe8 into openshift:main Jan 16, 2025
13 of 14 checks passed
@openshift-ci-robot
Copy link
Contributor

@muraee: Jira Issue OCPBUGS-45073: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-45073 has been moved to the MODIFIED state.

In response to this:

HCP is adding a new API field to allow users creating HCP clusters to set custom labels on all HCP pods openshift/hypershift#5114. cluster-csi-snapshot-controller-operator needs to integrate this feature in the same way it integrated the NodeSelector feature for HCP.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: ose-cluster-csi-snapshot-controller-operator
This PR has been included in build ose-cluster-csi-snapshot-controller-operator-container-v4.19.0-202501162138.p0.ga68ffe8.assembly.stream.el9.
All builds following this will include this PR.

@muraee
Copy link
Contributor Author

muraee commented Feb 4, 2025

/cherrypick release-4.18

@openshift-cherrypick-robot

@muraee: new pull request created: #227

In response to this:

/cherrypick release-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants