-
Notifications
You must be signed in to change notification settings - Fork 54
OCPBUGS-45073: Support HCP labels #223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@muraee: This pull request references Jira Issue OCPBUGS-45073, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
cc @jsafrane |
/jira refresh |
@muraee: This pull request references Jira Issue OCPBUGS-45073, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/retest |
/retest-required |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jsafrane, muraee The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/label acknowledge-critical-fixes-only |
/retest-required |
@muraee: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/retest-required |
a68ffe8
into
openshift:main
@muraee: Jira Issue OCPBUGS-45073: All pull requests linked via external trackers have merged:
Jira Issue OCPBUGS-45073 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
[ART PR BUILD NOTIFIER] Distgit: ose-cluster-csi-snapshot-controller-operator |
/cherrypick release-4.18 |
@muraee: new pull request created: #227 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
HCP is adding a new API field to allow users creating HCP clusters to set custom labels on all HCP pods openshift/hypershift#5114. cluster-csi-snapshot-controller-operator needs to integrate this feature in the same way it integrated the NodeSelector feature for HCP.